WordPress.org

Make WordPress Core

Opened 5 years ago

Closed 5 years ago

#13881 closed defect (bug) (fixed)

Twenty Ten: various *.css enhancement

Reported by: zeo Owned by: iandstewart
Milestone: WordPress.org Priority: normal
Severity: normal Version: 3.0
Component: Themes Keywords: has-patch
Focuses: Cc:

Description

Some part in Twenty Ten *.css that can and need to be improve.

Attachments (3)

13881-search-result-no-newline-class-page.diff (372 bytes) - added by zeo 5 years ago.
Only display: block if Page is other than search result
13881-search-result-no-newline-class-page.2.diff (372 bytes) - added by zeo 5 years ago.
Only display: block if body class is Page.
13881-use-lowercase-for-color-hex.diff (3.4 KB) - added by zeo 5 years ago.
use lower case letter in color hex code for consistency

Download all attachments as: .zip

Change History (8)

comment:1 @zeo5 years ago

#13860 - Twenty Ten: Odd CSS rule messes with password protected form for galleries

@zeo5 years ago

Only display: block if Page is other than search result

@zeo5 years ago

Only display: block if body class is Page.

@zeo5 years ago

use lower case letter in color hex code for consistency

comment:2 @zeo5 years ago

  • Should selector with no properties + value be removed?
  • For readability's and consistency sake:

add newline after each rule:

#main {
	overflow: hidden;
	padding: 40px 0 0 0;
}
#content {
	margin-bottom: 36px;
}

to this:

#main {
	overflow: hidden;
	padding: 40px 0 0 0;
}

#content {
	margin-bottom: 36px;
}

add whitespace:

background:#333;

to this:

background: #333;

comment:3 @zeo5 years ago

  • Owner set to iammattthomas
  • Status changed from new to assigned

comment:4 @zeo5 years ago

  • Owner changed from iammattthomas to iandstewart

comment:5 @iandstewart5 years ago

  • Resolution set to fixed
  • Status changed from assigned to closed

This'll be corrected in Twenty Ten 1.0.2 in the Themes Directory.

Note: See TracTickets for help on using tickets.