WordPress.org

Make WordPress Core

Opened 8 years ago

Closed 7 years ago

Last modified 7 years ago

#13891 closed defect (bug) (fixed)

Minor comment and coding standard cleanup in wp-config-sample.php

Reported by: TobiasBg Owned by: westi
Milestone: 3.1 Priority: lowest
Severity: trivial Version: 3.0
Component: General Keywords: has-patch
Focuses: Cc:

Description

wp-config-sample.php refers to the German translation with the language code "de", while the most common (and officially distributed) one is "de_DE", see http://de.wordpress.org/.

The same structure applies to most other languages, so the change in the comment might also aid users of other languages.

Attached patch also removes an extra space in the define call.

Attachments (4)

13891.patch (797 bytes) - added by TobiasBg 8 years ago.
Patch to fix language code and remove spaces
clipboard.txt (693 bytes) - added by hakre 7 years ago.
changes against trunk
mylyn-context.zip (3.1 KB) - added by hakre 7 years ago.
mylyn/context/zip
13891-2.diff (712 bytes) - added by zeo 7 years ago.
In [16124], westi left a couple of things out (spaces, _DE) from TobiasBg original patch. Patch refreshed against the current trunk.

Download all attachments as: .zip

Change History (13)

@TobiasBg
8 years ago

Patch to fix language code and remove spaces

#1 @wpmuguru
8 years ago

  • Keywords commit removed

At this stage commits need the approval of a lead.

#2 @nacin
8 years ago

wp-config-sample is translated in distributions, no? How, when, through what? Seems too late for 3.0, it's been around for a while.

#3 @westi
8 years ago

  • Milestone changed from 3.0 to 3.1
  • Owner set to westi
  • Status changed from new to accepted
  • Version set to 3.0

Trivial changes don't belong in 3.0 any more.

#4 @hakre
7 years ago

That's some explaining comment. +1 for the change, the reporter is right about the naming convention.

@hakre
7 years ago

changes against trunk

#5 @hakre
7 years ago

refreshed against current trunk

@hakre
7 years ago

mylyn/context/zip

#6 @markmcwilliams
7 years ago

Worth looking at sneaking it in for 3.1 Peter?

#7 @westi
7 years ago

  • Resolution set to fixed
  • Status changed from accepted to closed

(In [16124]) Improve WPLANG example. Fixes #13891 props TobiasBg.

#8 @westi
7 years ago

  • Milestone changed from Awaiting Triage to 3.1

@zeo
7 years ago

In [16124], westi left a couple of things out (spaces, _DE) from TobiasBg original patch. Patch refreshed against the current trunk.

#9 @westi
7 years ago

(In [16131]) Apply the missing bits of the patch. Fixes #13891 props TobiasBg and zeo

Note: See TracTickets for help on using tickets.