Make WordPress Core

Opened 16 years ago

Closed 16 years ago

Last modified 16 years ago

#13897 closed defect (bug) (fixed)

Typo in class-http.php

Reported by: filosofo Owned by:
Priority: normal Milestone: 3.0.1
Component: HTTP API Version: 3.0
Severity: normal Keywords: has-patch dev-feedback
Cc: Focuses:

Description

"scheme" is an array index of $arrURL, not $url (a string).

Attachments (3)

http-request-typo.13897.diff (480 bytes ) - added by filosofo 16 years ago.
13897.patch (5.3 KB ) - added by hakre 16 years ago.
13897.2.patch (3.4 KB ) - added by hakre 16 years ago.

Download all attachments as: .zip

Change History (11)

#1 @hakre
16 years ago

just saw, in case someone is on it, let some whitespace in 241:

$arrURL = parse_url( $url );

@hakre
16 years ago

#2 @hakre
16 years ago

While we did a review in IRC and I had my fingers in that file fixing whitespaces in that function I just added it here.

Nice find of the problem btw, the faulty code never does notices. I would even consider to see the single problem fixed in 3.0.0.

#3 @dd32
16 years ago

  • Resolutionfixed
  • Status newclosed

(In [15283]) Fix typo in HTTP Class. Props filosofo. Fixes #13897 for 3.0

#4 @dd32
16 years ago

(In [15284]) Fix typo in HTTP Class. Props filosofo. Fixes #13897 for trunk

#5 @dd32
16 years ago

(In [15285]) Some coding standards cleanups for WP_HTTP. Props hakre for initial patch. See #13897

@hakre
16 years ago

#6 @hakre
16 years ago

A little coding update against very current trunk, those whitespace / coding standards cleanups have not been taken in yet.

#7 @hakre
16 years ago

  • Keywords dev-feedback added

#8 @nacin
16 years ago

(In [15309]) Some whitespace in WP_HTTP. props hakre, see #13897.

Note: See TracTickets for help on using tickets.