WordPress.org

Make WordPress Core

Opened 6 years ago

Closed 6 years ago

#13902 closed defect (bug) (fixed)

Invalid markup in import.php

Reported by: wahgnube Owned by:
Milestone: 3.0 Priority: normal
Severity: trivial Version: 3.0
Component: Validation Keywords: has-patch dev-feedback
Focuses: Cc:

Description

I have attached a tiny patch for wp-admin/import.php. This replaces
some & characters with &, making the page valid XHTML.

Attachments (4)

import.patch (685 bytes) - added by wahgnube 6 years ago.
import-2.patch (688 bytes) - added by wahgnube 6 years ago.
import-3.patch (688 bytes) - added by wahgnube 6 years ago.
13902.patch (1.9 KB) - added by ocean90 6 years ago.

Download all attachments as: .zip

Change History (11)

@wahgnube
6 years ago

#1 @wahgnube
6 years ago

  • Milestone changed from Unassigned to 3.0

#2 @ocean90
6 years ago

  • Keywords needs-patch added; has-patch removed
  • Version set to 3.0

You shoud use esc_url().

#3 @wahgnube
6 years ago

  • Keywords has-patch added; needs-patch removed

I have done so.

@wahgnube
6 years ago

#4 @ocean90
6 years ago

Better is:

esc_url( admin_url( 'xxxx' ) )

:-)

#5 @wahgnube
6 years ago

I meant to do that, really! :)

@wahgnube
6 years ago

@ocean90
6 years ago

#6 @ocean90
6 years ago

  • Keywords dev-feedback added

13902.patch is only a cosmetic patch,it includes the patch from wahgnube too.

#7 @nacin
6 years ago

  • Resolution set to fixed
  • Status changed from new to closed

(In [15264]) Two birds with one stone. fixes #13902, props ocean90, wahgnube. fixes #13555, props hakre.

Note: See TracTickets for help on using tickets.