WP_User object conditional failures

[filosofo]

A number of places check whether a user object has instantiated the data of an actual user by either checking whether the user object is empty or falsely. Both checks will fail to come to the correct conclusion because $user is an object that has default properties and methods.

$user = new WP_User( 0 ); // not a user's ID

var_dump( empty( $user ) ); // false!
var_dump( ! $user ); // false !
var_dump( empty( $user->ID ) ); // true; that's more like it

[nacin]

Looks good.

[nacin]

(In [15403]) Fix checking for whether WP_User object is actually a user. props filosofo, fixes #13903 for 3.0.

[nacin]

(In [15404]) Fix checking for whether WP_User object is actually a user. props filosofo, fixes #13903 for trunk.