Don’t nag to Change Permalinks if permalink structure is defined

[demetris]

The Post Edit screen nags you to Change Permalinks even for non-default permalink structures like:

/archives/%post_id% (example given by WP itself)

or

/%post_id%

Is there a reason WordPress checks in the way it does, instead of, for example, just checking whether permalink_structure is set, and then nagging accordingly?

The code is in get_sample_permalink_html:

​http://core.trac.wordpress.org/browser/trunk/wp-admin/includes/post.php#L1065

[demetris]

Tentative patch to nag only when permalink_structure is empty.

(Personally I dislike the nag even then, but I don’t know what is most useful for the majority of WP users.)

[demetris]

More sensible nagging to Change Permalinks

[nacin]

Looks sane. Branching could be merged on the patch, though.

[demetris]

I suppose nacin’s comment means to add the check to the same IF, without nesting. I updated the patch accordingly, against the current trunk.

One other thing: I am not certain which way is better for checking whether the option does not have a value:

!get_option('permalink_structure')

or

get_option('permalink_structure') == ''

[demetris]

Adds check to the same IF, without nesting

[ryan]

(In [16651]) Don’t nag to Change Permalinks if permalink structure is defined. Props demetris. fixes #13918