WordPress.org

Make WordPress Core

Opened 15 years ago

Closed 15 years ago

Last modified 14 years ago

#1393 closed defect (bug) (fixed)

extraneous check in wp_login()

Reported by: skippy Owned by: skippy
Milestone: Priority: low
Severity: trivial Version:
Component: Optimization Keywords: bg|has-patch bg|commit
Focuses: Cc:

Description

if ( ($already_md5 && $login->user_login == $username && md5($login->user_pass) == $password)
($login->user_login == $username && $login->user_pass == md5($password)) )

$username will _always_ match $login->user_login, because $username was used to fetch the data from the database.

Attachments (2)

pluggable-functions.diff (346 bytes) - added by skippy 15 years ago.
pluggable-functions.php.diff (732 bytes) - added by markjaquith 15 years ago.
patch for 1.6 SVN

Download all attachments as: .zip

Change History (9)

#1 @skippy
15 years ago

  • Patch set to No

#2 @skippy
15 years ago

  • Keywords bg|has-patch bg|2nd-opinion added
  • Owner changed from anonymous to skippy
  • Priority changed from normal to low
  • Status changed from new to assigned

@markjaquith
15 years ago

patch for 1.6 SVN

#3 @markjaquith
15 years ago

  • Keywords bg|commit added; bg|2nd-opinion removed

Yep, you're right. Your patch wasn't working for me though... some line at the end:

< ?>
\ No newline at end of file
---
> ?>

::shrugs:: I uploaded one I made.

#4 @skippy
15 years ago

  • Milestone set to 1.5.2

#5 @matt
15 years ago

  • Milestone changed from 1.5.2 to 1.6

#6 @matt
15 years ago

  • Resolution set to fixed
  • Status changed from assigned to closed

(In [2806]) Optimization from Skippy, fixes #1393

#7 @(none)
14 years ago

  • Milestone 2.0 deleted

Milestone 2.0 deleted

Note: See TracTickets for help on using tickets.