WordPress.org

Make WordPress Core

Opened 10 years ago

Closed 10 years ago

Last modified 10 years ago

#13948 closed defect (bug) (fixed)

Wrong link on Updates screen

Reported by: pavelevap Owned by: ryan
Milestone: 3.0.1 Priority: normal
Severity: normal Version: 3.0
Component: Upgrade/Install Keywords: has-patch i18n-change
Focuses: Cc:

Description

Upgrading from latest SVN to WP 3.0.

There is info about new version, but with wrong link:

http://codex.wordpress.org/Version_3.0–%3Cstrong%3Een_US%3C/strong%3E

Attachments (1)

13948.patch (1001 bytes) - added by ocean90 10 years ago.

Download all attachments as: .zip

Change History (14)

@ocean90
10 years ago

#1 @ocean90
10 years ago

  • Keywords has-patch added

We should use for the codex link only the version number.

#2 @ocean90
10 years ago

Seems like there is more: http://grab.by/4ZNR

<p>Du kannst automatisch auf <a href="http://codex.wordpress.org/Version_3.0–&lt;strong&gt;de_DE&lt;/strong&gt;">WordPress 3.0–<strong>de_DE</strong></a> aktualisieren oder das Paket herunterladen und manuell installieren:</p>

<p>Du kannst automatisch auf <a href="http://codex.wordpress.org/Version_http://wordpress.org/wordpress-3.0.zip–&lt;strong&gt;3.0&lt;/strong&gt;">WordPress http://wordpress.org/wordpress-3.0.zip–<strong>3.0</strong></a> aktualisieren oder das Paket herunterladen und manuell installieren

<a href="http://wordpress.org/download/" class="button">http://wordpress.org/wordpress-3.0.zip–<strong>3.0</strong> herunterladen</a>

#3 @ocean90
10 years ago

  • Keywords needs-patch added; has-patch removed

$update->current is initially 3.0 and then the download url http://wordpress.org/wordpress-3.0.zip

#4 @nacin
10 years ago

Done in [13250]. If anyone wishes to go through each of those, it'd be appreciated.

#5 @nacin
10 years ago

  • Keywords i18n-change added

#6 @ocean90
10 years ago

  • Component changed from General to Upgrade/Install

I think there is a problem with get_core_updates(). Language is German and normally my patch should work for this sentence, but only for the first one.
The output of get_core_updates() is: http://pastebin.org/338532

#7 @dd32
10 years ago

  • Component changed from Upgrade/Install to WordPress.org

The format being returned by the Update API seems to be incompatible with the parser inside wordpress, Not only that, but it seems to be returning some data incorrectly.

http://api.wordpress.org/core/version-check/1.5/?version=0.1&php=5.2&locale=de_DE&mysql=4.3&local_package=&blogs=1&users=1&multisite_enabled=0

There are 2 blank lines between the sections instead of 1, and that serialised PHP should be the required PHP version for that version of WordPress.. It doesnt appear to be a problem in core at all.

#8 @ocean90
10 years ago

  • Keywords has-patch added; needs-patch removed
  • Owner set to rboren
  • Status changed from new to reviewing

Okay, so my patch is okay, we need a change in th API, I think it's ryan's part.

#9 @ocean90
10 years ago

  • Owner changed from rboren to ryan

#10 @ryan
10 years ago

api.wordpress.org should be fixed now.

#11 @dd32
10 years ago

  • Component changed from WordPress.org to Upgrade/Install

Trac needs multiple Milestones per ticket.

Moving back to upgrade for strings changes.

#12 @dd32
10 years ago

  • Resolution set to fixed
  • Status changed from reviewing to closed

(In [15281]) Correct the links to the codex for non-english users. Props ocean90. Fixes #13948 for trunk

#13 @dd32
10 years ago

(In [15282]) Correct the links to the codex for non-english users. Props ocean90. Fixes #13948 for 3.0

Note: See TracTickets for help on using tickets.