WordPress.org

Make WordPress Core

Opened 4 years ago

Closed 4 years ago

Last modified 4 years ago

#13960 closed defect (bug) (fixed)

LiveJournal Importer broken in 3.0

Reported by: grahams Owned by: filosofo
Milestone: 3.1 Priority: normal
Severity: normal Version: 3.0
Component: Import Keywords: has-patch
Focuses: Cc:

Description

I tried to import my LJ (grahams.livejournal.com) into a clean WordPress 3.0 installation. After inputting my LJ username and password, as well as a protected post password, I clicked the "Connect to Livejournal and Import" button. After it churned for awhile I got the following error:

Import LiveJournal

Warning: include(/var/www/wp3/wp-admin/import/livejournal.php) [function.include]: failed to open stream: No such file or directory in /var/www/wp3/wp-admin/admin-ajax.php on line 1378

Warning: include() [function.include]: Failed opening '/var/www/wp3/wp-admin/import/livejournal.php' for inclusion (include_path='.:/usr/share/php:/usr/share/pear') in /var/www/wp3/wp-admin/admin-ajax.php on line 1378

Fatal error: Call to a member function step1() on a non-object in /var/www/wp3/wp-admin/admin-ajax.php on line 1379

Attachments (2)

remove-livejournal-import-vestige.13960.diff (741 bytes) - added by filosofo 4 years ago.
ljimporter.diff (1.0 KB) - added by nacin 4 years ago.

Download all attachments as: .zip

Change History (13)

comment:1 filosofo4 years ago

Here's part of what needs to happen to fix this, on the core WP side. The remainder needs to happen with the Livejournal import plugin.

comment:2 nacin4 years ago

  • Milestone changed from Awaiting Review to WordPress.org site

comment:3 filosofo4 years ago

  • Keywords has-patch added
  • Milestone changed from WordPress.org site to 3.1
  • Owner set to filosofo
  • Status changed from new to assigned

Patch still applies. Can we at least get rid of that vestige LJ importer code in admin-ajax, please?

Then switch it back to WordPress.org.

comment:4 nacin4 years ago

Diff for the importer attached. Will commit there but I don't have anything to easily test this on and I don't feel like releasing a borked 0.3 version.

nacin4 years ago

comment:5 RyanMurphy4 years ago

patched importer works for me

comment:6 westi4 years ago

  • Cc westi added

Going to commit this.

Tagged v0.20 in prep for updating and then Tagging v0.30.

It may be worth renaming the AJAX action so it doesn't clash with the vestige.

comment:7 westi4 years ago

@nacin: I have to say I think this line in your patch might not be needed ;-)

include( ABSPATH . 'wp-admin/import/livejournal.php' );

comment:8 nacin4 years ago

Indeed, that's just a copy-paste vestige from admin-ajax.

comment:9 westi4 years ago

http://plugins.trac.wordpress.org/changeset/310423

Updated the Importer Plugin.

Testing != fun when you get blocked for hitting the API too much

comment:10 westi4 years ago

  • Resolution set to fixed
  • Status changed from assigned to closed

(In [16293]) Chop this off as we don't need it anymore. Fixes #13960 props filosofo.

comment:11 westi4 years ago

New plugin version is live.
Worked for me with my new test LJ site.

Note: See TracTickets for help on using tickets.