WordPress.org

Make WordPress Core

Opened 5 years ago

Closed 4 years ago

#13968 closed defect (bug) (fixed)

Post parent title in postrow isn't handled internally

Reported by: johnjamesjacoby Owned by:
Milestone: 3.1 Priority: normal
Severity: minor Version:
Component: Administration Keywords: has-patch, needs-testing
Focuses: Cc:

Description

The $title of the post_parent is gathered and rendered without any internal processes touching it. This patch runs it through get_the_title.

I haven't swept through to see if there are other places this happens. I have another ticket that does something similar for the page dropdown walker class though.

Attachments (2)

better_post_parent.patch (382 bytes) - added by johnjamesjacoby 5 years ago.
13968.patch (525 bytes) - added by garyc40 4 years ago.

Download all attachments as: .zip

Change History (10)

comment:1 @johnjamesjacoby5 years ago

Reference ticket #13668. Maybe we should start a master ticket somewhere to audit places where page titles, post titles, and custom post titles aren't being filtered.

comment:2 @nacin5 years ago

  • Keywords has-patch added
  • Milestone changed from 3.0.1 to 3.1

Not a regression.

comment:3 @nacin5 years ago

  • Keywords commit added

comment:4 @nacin5 years ago

Re: audit, #4893.

comment:5 follow-up: @ryan5 years ago

Doesn't that get the grandparent's name rather than the parent?

comment:6 in reply to: ↑ 5 @nacin5 years ago

  • Keywords needs-patch added; has-patch commit removed

Replying to ryan:

Doesn't that get the grandparent's name rather than the parent?

Indeed.

@garyc404 years ago

comment:7 @garyc404 years ago

  • Keywords has-patch needs-testing added; needs-patch removed

comment:8 @scribu4 years ago

  • Resolution set to fixed
  • Status changed from new to closed

(In [16908]) Run parent title through 'the_title'. Props garyc40. Fixes #13968

Note: See TracTickets for help on using tickets.