comment_max_links discrepency

[chrisdolan]

In WP v1.5.1, the Options-Discussion page has an field labeled:

"Hold a comment in the queue if it contains more than N links."

However, it appears that the code enforces this as "more than equal to". This discrepency causes confusion.

[nmoog]

The options->discussion page says "Hold a comment in the queue if it contains more than X links." but the code check in code had ">= get_settings('comment_max_links')" instead of just more-than.

(note - i sleepily entered the description on the patch as "less-than" not "more-than". Sorry.)

[nmoog]

I got MarkJaquith to remove the patch, as he pointed out it is probably better to change the wording on the options-discussion.php page rather than change the code.

I was going to patch the options-discussion.php to say "Hold a comment in the queue if it contains %s or more links", though I do not know how that would affect language translations.

So I'll leave this executive decision to someone else.

[Nazgul]

Fixed the wording so it actually says what the code does.

[Nazgul]

2.0.5 Candidate

[markjaquith]

(In [4303]) Clarify comment_max_links option text. Props chrisdolan and Nazgul. fixes 1397

I'll get this auto-close format right eventually!

fixes #1397

fixes #1397

[foolswisdom]

[44304] same fix for branches/2.0 -> 2.0.5

[(none)]

Milestone 2.0.5 deleted