WordPress.org

Make WordPress Core

Opened 10 years ago

Closed 9 years ago

Last modified 9 years ago

#1397 closed defect (bug) (fixed)

comment_max_links discrepency

Reported by: chrisdolan Owned by:
Milestone: Priority: normal
Severity: minor Version: 1.5.1
Component: Administration Keywords: has-patch
Focuses: Cc:

Description

In WP v1.5.1, the Options-Discussion page has an field labeled:

"Hold a comment in the queue if it contains more than N links."

However, it appears that the code enforces this as "more than equal to". This discrepency causes confusion.

Attachments (2)

1397.diff (1.2 KB) - added by Nazgul 9 years ago.
1397_20.diff (1.2 KB) - added by Nazgul 9 years ago.

Download all attachments as: .zip

Change History (10)

comment:1 @chrisdolan10 years ago

  • Patch set to No

comment:2 @nmoog10 years ago

The options->discussion page says "Hold a comment in the queue if it contains more than X links." but the code check in code had ">= get_settings('comment_max_links')" instead of just more-than.

(note - i sleepily entered the description on the patch as "less-than" not "more-than". Sorry.)

comment:3 @nmoog10 years ago

I got MarkJaquith to remove the patch, as he pointed out it is probably better to change the wording on the options-discussion.php page rather than change the code.

I was going to patch the options-discussion.php to say "Hold a comment in the queue if it contains %s or more links", though I do not know how that would affect language translations.

So I'll leave this executive decision to someone else.

@Nazgul9 years ago

comment:4 @Nazgul9 years ago

  • Keywords has-patch added
  • Milestone set to 2.1

Fixed the wording so it actually says what the code does.

@Nazgul9 years ago

comment:5 @Nazgul9 years ago

  • Milestone changed from 2.1 to 2.0.5

2.0.5 Candidate

comment:6 @markjaquith9 years ago

  • Resolution set to fixed
  • Status changed from new to closed

(In [4303]) Clarify comment_max_links option text. Props chrisdolan and Nazgul. fixes 1397

I'll get this auto-close format right eventually!

fixes #1397

fixes #1397

comment:7 @foolswisdom9 years ago

[44304] same fix for branches/2.0 -> 2.0.5

comment:8 @anonymous9 years ago

  • Milestone 2.0.5 deleted

Milestone 2.0.5 deleted

Note: See TracTickets for help on using tickets.