Opened 14 years ago
Closed 14 years ago
#13978 closed enhancement (fixed)
Empty Site Title issues
Reported by: | mrmist | Owned by: | |
---|---|---|---|
Milestone: | 3.1 | Priority: | normal |
Severity: | normal | Version: | 3.0 |
Component: | Administration | Keywords: | has-patch |
Focuses: | Cc: |
Description
If your site has no "site title" in Settings, then the "visit site" link in the admin header is an invisible (though still available) link.
I think one of the following is needed -
- A blank "Site Title" is not allowed through Settings.
or
- If the "Site Title" is blank, there should be some default text placed into the "visit site" link, so that it has some visible content.
or
- Both 1 & 2.
Attachments (5)
Change History (16)
#1
@
14 years ago
- Component changed from General to Administration
- Type changed from defect (bug) to enhancement
#2
@
14 years ago
Ahh I see you also created a patch... Mine is slightly different because I wasn't sure if the ' ' value was used elsewhere for other things, so I only altered the actual link text.
#4
@
14 years ago
Well, we could make it so that the user couldn't even submit a blank site title if they wanted. But, we should wait until one of the big devs stops by to offer some insight. :D
#5
@
14 years ago
- Keywords dev-feedback added
This will redirect the user back to options-general.php if the site title is blank. And it adds in your patch since it would cause less issues in other areas of the site.
#6
@
14 years ago
We currently account for blogname to be , based on the code seen in the first diff. So I'm not sure if we necessarily need to block empty values there.
Setting it to "Visit Site" instead of " " seems like it'll make sense. Though that would need to be translated. It's not a new string as "Visit Site" is used in the title attribute there, so we can probably add this to 3.0.1.
@
14 years ago
I created this patch before I realized anyone else was working on it... so I'm just submitting it cause I create it.
#9
@
14 years ago
- Keywords dev-feedback removed
It was previously nbsp because we had the small "Visit Site" button before 3.0.
I think we can go to "Visit Site". Alternatively, we could go to "WordPress".
Add visit site to the site header.