WordPress.org

Make WordPress Core

Opened 11 years ago

Closed 11 years ago

#13978 closed enhancement (fixed)

Empty Site Title issues

Reported by: mrmist Owned by:
Milestone: 3.1 Priority: normal
Severity: normal Version: 3.0
Component: Administration Keywords: has-patch
Focuses: Cc:

Description

If your site has no "site title" in Settings, then the "visit site" link in the admin header is an invisible (though still available) link.

I think one of the following is needed -

  1. A blank "Site Title" is not allowed through Settings.

or

  1. If the "Site Title" is blank, there should be some default text placed into the "visit site" link, so that it has some visible content.

or

  1. Both 1 & 2.

Attachments (5)

13978.patch (432 bytes) - added by sean212 11 years ago.
Add visit site to the site header.
admin-header.patch (1.0 KB) - added by mrmist 11 years ago.
Admin header patch
13978-fix.patch (1.7 KB) - added by sean212 11 years ago.
Try this on for size.
admin-header.diff (1021 bytes) - added by layotte 11 years ago.
I created this patch before I realized anyone else was working on it... so I'm just submitting it cause I create it.
15120.diff (462 bytes) - added by blepoxp 11 years ago.
Running off revision 15805. Replaces   with ( 'Visit Site' );

Download all attachments as: .zip

Change History (16)

#1 @sean212
11 years ago

  • Component changed from General to Administration
  • Type changed from defect (bug) to enhancement

@sean212
11 years ago

Add visit site to the site header.

@mrmist
11 years ago

Admin header patch

#2 @mrmist
11 years ago

Ahh I see you also created a patch... Mine is slightly different because I wasn't sure if the ' ' value was used elsewhere for other things, so I only altered the actual link text.

#3 @mrmist
11 years ago

  • Keywords has-patch added

#4 @sean212
11 years ago

Well, we could make it so that the user couldn't even submit a blank site title if they wanted. But, we should wait until one of the big devs stops by to offer some insight. :D

@sean212
11 years ago

Try this on for size.

#5 @sean212
11 years ago

  • Keywords dev-feedback added

This will redirect the user back to options-general.php if the site title is blank. And it adds in your patch since it would cause less issues in other areas of the site.

#6 @nacin
11 years ago

We currently account for blogname to be , based on the code seen in the first diff. So I'm not sure if we necessarily need to block empty values there.

Setting it to "Visit Site" instead of " " seems like it'll make sense. Though that would need to be translated. It's not a new string as "Visit Site" is used in the title attribute there, so we can probably add this to 3.0.1.

@layotte
11 years ago

I created this patch before I realized anyone else was working on it... so I'm just submitting it cause I create it.

#7 @blepoxp
11 years ago

Attaching my patch from #15120.

@blepoxp
11 years ago

Running off revision 15805. Replaces   with ( 'Visit Site' );

#8 @ryan
11 years ago

  • Keywords ux-feedback added
  • Milestone changed from Awaiting Triage to 3.1

#9 @nacin
11 years ago

  • Keywords dev-feedback removed

It was previously nbsp because we had the small "Visit Site" button before 3.0.

I think we can go to "Visit Site". Alternatively, we could go to "WordPress".

#10 @jane
11 years ago

  • Keywords ux-feedback removed

@nacin: why would we go with "WordPress" for a visit site link? Visit site.

#11 @nacin
11 years ago

  • Resolution set to fixed
  • Status changed from new to closed

(In [15992]) Use 'Visit Site' in header if blog has no name. props blepoxp, fixes #13978.

Note: See TracTickets for help on using tickets.