Menu Item "Home" won't have class "current-menu-item" in case of there are query string in the home url

[kamiyeye]

Repro steps:
==========

1. Add "Home" to the navigation menu
   
2. Navigate to ​http://thetestsite/?style=stylename[[BR]]
3. Check the css class of "Home" on the navigation menu
   

Expected:
==========
There is the class "current-menu-item"

Actual:
==========
There isn't the class "current-menu-item"

Desc:
==========

1. It works when there are no query string in the url say: ​http://thetestsite/[[BR]]
2. It is related to Changeset 14457

[ocean90]

Related #13977

[kamiyeye]

Repro steps:
==========

1. Add "Home" to the navigation menu
   
2. Navigate to ​http://thetestsite/?style=stylename
   
3. Check the css class of "Home" on the navigation menu
   

Expected:
==========
There is the class "current-menu-item"

Actual:
==========
There isn't the class "current-menu-item"

Description:
==========

1. It works when there are no query string in the url say: ​http://thetestsite/
   
2. It is related to Changeset 14457

[filosofo]

How would you propose that WP go about determining which query strings make a significant-enough change to warrant saying the page is no longer the same? In this example presumably the only change has to do with the active stylesheet, but most query strings change the content.

I propose that any plugins or themes that use these strings take on the responsibility of handling the menu classes, as they're in the best (really--the only) position of being able to make that decision.

[kamiyeye]

Query based on request url should have happened this time, can we use query results or relevant methods to handle this problem? is_home()?

[filosofo]

The problem is not identifying the current query; it's matching it to the menu item's URL.

Menu item's URL: http://site.com/

Requested page: http://site.com/?foo=bar

How should WP know that the second is supposed to be equivalent to the first?

[kamiyeye]

I think we are talking about the possibility of resolve this issue, right? Any reason we have to stick to the way by comparing url?
Have a try with is_home() on ​http://testsite/?que=ry, see true or false.

[filosofo]

Thinking about this some more, I think this could be useful for matching the home URL when pages are involved, too.

Try front-page-current-class.13994.diff to see if that solves the problem for you.

[kamiyeye]

Cool, it works! Will it be added to wp version 3.0.1?

[filosofo]

Patch is still fresh.

[westi]

When is this code meant to trigger?

​http://trunk.domain/?foo=bar which seems to be what the ticket is talking about doesn't trigger it.

[filosofo]

Apparently someone's been untrailingslashitting stuff in the last half year.

Patch refreshed.

[markjaquith]

(In [16742]) Highlight home page Custom Nav Menu item even when extra query args are present in the URL (only if all other highlights fail). props filosofo. fixes #13994