Inconsistency in arguments when wp_nav_menu falls back to wp_page_menu

[Utkarsh]

​wp_nav_menu's 'menu_class' parameter applies the class to the <ul>.

The default fallback function ​wp_page_menu however, applies 'menu_class' to the <div> enclosing the <ul>.

This can cause inconsistent styles if the style is applied to ul.<menu class>

[nacin]

Related #13979

[nacin]

Needs patch or punt.

[Sanjo]

wp_page_menu() has now a container_class and a menu_class argument that are identical to wp_nav_menu.

[Sanjo]

Added documentation

[nacin]

We can't change how wp_page_menu() works. We'll need to add a ul_class argument to wp_page_menu and re-map menu_class to ul_class in wp_nav_menu before passing it to wp_page_menu.

[Frank Klein]

The updated patch with contains the following elements:

• Add a ul_class argument to wp_page_menu.
• Remap the menu_class from wp_nav_menu to ul_class before passing it to wp_page_menu.
• Updated inline documentation.
• Some whitespace fixes and other code standards adaptations.

I think that there are other possible enhancements that can be added to the wp_page_menu function, specifically some of the arguments used by wp_nav_menu such as:

• container
• container_id
• menu_id
• before
• after
• items_wrap
• depth

As far as I see, it should be possible to implement these arguments in wp_page_menu as well without breaking existing themes. I think especially the depth argument might be a worthwhile addition, what do you think?

[yarco]

I get the problem in v3.9... menu_class will be always assigned to the container...
So what is the current resolution?

[Frank Klein]

The refreshed patch only deals with adding the menu_class to the <ul> in case of a fallback.

I think this would make sense to include in 4.4, since it's related to #11095.

[chriscct7]

4.4's enhancement window is closed. It can however be submitted for 4.5