Make WordPress Core

Opened 5 years ago

Last modified 5 months ago

#14039 assigned enhancement

Consolidate strings with same meaning but different wording

Reported by: demetris Owned by: demetris
Milestone: Future Release Priority: normal
Severity: normal Version: 3.0
Component: Text Changes Keywords: needs-patch ux-feedback
Focuses: administration Cc:


While translating WordPress I often come upon couples or triplets of strings that mean the same thing but are worded differently. I would like to start consolidating such strings by selecting a preferable version and replacing the other instances with it.

Here is one example:

  • You are not allowed to edit this page. <- The one to keep.
  • Sorry, you cannot edit this page.
  • Sorry, you do not have the right to edit this page.

Here is another:

  • Submit Comment
  • Post Comment <- $label_submit in comment_form()

Before making any patches, I will post all cases here for review and feedback.

The milestone for this would be 3.1, but it seems that I have been designated an “unknown Trac user” and I cannot set milestone and priority.

Change History (15)

comment:1 @nacin5 years ago

  • Milestone changed from Unassigned to 3.1

As explained, we are trying to prevent scope creep and improve our workflow. Given the dozens of us who read literally every ticket as they are posted, it makes sense to restrict a few fields (priority and milestone) to ensure they can be trusted and useful.

I am all for consolidating strings; patch away. I know Nikolay has talked about a review of all strings in core for inconsistent tone, word choice, similarity, etc., but it's quite the project that realistically needs to go through person to ensure consistency. (If you want to start offering huge patches to that effect, I will gladly assign this ticket to you.)

comment:2 @demetris5 years ago

  • Owner set to demetris
  • Status changed from new to assigned


I assigned the ticket to myself. I will not be submitting huge patches soon (that is, not within the next few days). I want to look at the strings carefully.

Also, my initial plan was to use this ticket only for consolidation, not for standardization. That is, not for changes that will introduce new strings into the POT by tweaking and by fixing typos/capitalization/punctuation/etc. But I’ll see how that goes.

Standardization would introduce a large number of new strings. For an indication, see the different wordings we use now in messages about insufficient capabilities:

  • You are not allowed to
  • You do not have the right to
  • You do not have permission to
  • You do not have sufficient permissions to
  • You cannot


Feedback appreciated!

comment:3 @hakre5 years ago

Related #14060

comment:4 @hakre5 years ago

Related: #14972

comment:5 @nacin5 years ago

  • Milestone changed from Awaiting Triage to Future Release

comment:6 follow-up: @demetris4 years ago

Closed #18218 as duplicate of this.

comment:7 in reply to: ↑ 6 @ramiy4 years ago

Replying to demetris:

Closed #18218 as duplicate of this.

Demetris, i don't think #18218 is a duplicate. This ticket (14039) presenting a concept and guidelines for the future, #18218 shows specific strings that can be changed right now.

Last edited 4 years ago by ramiy (previous) (diff)

comment:8 @ramiy4 years ago

  • Cc r_a_m_i@… added

comment:10 follow-up: @scribu4 years ago

+1 on taking care of the strings in #18218 now.

Better to break this into multiple steps.

comment:11 in reply to: ↑ 10 @ramiy4 years ago

Replying to scribu:

+1 on taking care of the strings in #18218 now.

Better to break this into multiple steps.

scribu, also check out the paches i added to #7098, some of them related to the strings in #18218.

comment:12 @steveagl4 years ago

  • Cc steveagl added

comment:13 @ocean903 years ago

  • Cc ocean90 added

comment:14 @SergeyBiryukov3 years ago

  • Component changed from UI to Text Changes

comment:15 @chriscct75 months ago

  • Focuses administration added
  • Keywords needs-patch ux-feedback added
Note: See TracTickets for help on using tickets.