WordPress.org

Make WordPress Core

Opened 10 years ago

Closed 10 years ago

#14051 closed defect (bug) (fixed)

Cannot remove super admin privileges from user

Reported by: andrejcarter Owned by:
Milestone: 3.1 Priority: normal
Severity: normal Version: 3.0
Component: Role/Capability Keywords: has-patch
Focuses: Cc:

Description

I cannot remove super admin privileges. I login using a different super admin account, click on users in the super admin section, select the user, uncheck the "Grant this user super admin privileges for the Network." box, and click save, but the user still has super admin privileges. I've tried this several times using Firefox 3.6.3 and Safari 5.0 (6533.16).

Attachments (1)

14051.diff (2.5 KB) - added by duck_ 10 years ago.

Download all attachments as: .zip

Change History (12)

#1 @ocean90
10 years ago

  • Keywords reporter-feedback added; Super admin privileges remove delete removed

Any plugins active? Is it a fresh install or WPMU -> Multisite upgrade?
It works fine for me.

#2 @gazouteast
10 years ago

UNder 2.9.2 there was also a box for typing in the user names with admin privileges - is there similar in 3.0 for super admins?

In 2.9.2 you set the user as an admin, then went to the other page and granted them site-wide admin role by adding (typing) their username into the box.

#3 @ipstenu
10 years ago

In 3.0.1 I can reproduce this error.

I go in to edit user No. 1 (I'm No. 2). I UNCHECK Grant this user super admin privileges for the Network. and click save.

It comes back and is still checked.

See also: http://wordpress.org/support/topic/cant-remove-super-admin-privileges

#4 follow-up: @andrea_r
10 years ago

if the Network Admin email address is the same as any Super Admin, then you cannot remove them as a super admin.

I'm 99% that's how Ron coded it up.

#5 in reply to: ↑ 4 ; follow-up: @nacin
10 years ago

Replying to andrea_r:

I'm 99% that's how Ron coded it up.

That's correct. Ref: revoke_super_admin(): http://core.trac.wordpress.org/browser/trunk/wp-admin/includes/ms.php?rev=15590#L745

Would have been nicer had I written those functions to return WP_Error. We can probably still do that, as I doubt anyone is really checking the return values of those functions. But in lieu of that, we can hide that checkbox and add a string noting that the network admin email matches this user.

It's worth noting that the network admin email does not make a super admin. It simply prevents them from losing their privileges. Seems inconsistent.

#6 in reply to: ↑ 5 @wpmuguru
10 years ago

Replying to nacin:

It's worth noting that the network admin email does not make a super admin. It simply prevents them from losing their privileges. Seems inconsistent.

What if when the network admin email address was changed, there was check added to look for that user and add the user (if it exists) to the super admin list?

#7 @ipstenu
10 years ago

Why does the network admin email's ID need to be a super-user at all? If it has to be, then a drop down for 'Emails should be sent from this user account:' listing the admins or super-admins would cover both bases.

If it's totally unrelated, make it unrelated all across the board.

#8 @mrmist
10 years ago

probably another example of where site owner / technical contact "roles" would be useful (to cover off the email address stuff.)

#9 @nacin
10 years ago

  • Keywords reporter-feedback removed
  • Milestone changed from Awaiting Review to 3.1

@duck_
10 years ago

#10 @duck_
10 years ago

  • Keywords has-patch added

Also fixed misplaced closing </td></tr> appearing for single site and removed checkbox/notice from display when IS_PROFILE_PAGE

#11 @ryan
10 years ago

  • Resolution set to fixed
  • Status changed from new to closed

(In [16767]) Don't show super admin checkbox for the user that has the network admin email address. Props duck_. fixes #14051

Note: See TracTickets for help on using tickets.