WordPress.org

Make WordPress Core

Opened 4 years ago

Last modified 8 months ago

#14078 new enhancement

Don't send notifications for comments too early

Reported by: mrmist Owned by:
Milestone: Future Release Priority: normal
Severity: normal Version: 3.0
Component: Comments Keywords: has-patch needs-testing
Focuses: Cc:

Description

Not sure if this classes as a bug or enhancement, will call it an enhancement for now.

In wp_set_comment_status the notifications are currently sent out before the work is done, and there is potential for the subsequent work to fail (due to database issue etc.)

Attached patch (attempts to) move the notification so it is only sent after the work is done.

Attachments (1)

send_notification_later.patch (743 bytes) - added by mrmist 4 years ago.
Move notifications

Download all attachments as: .zip

Change History (4)

mrmist4 years ago

Move notifications

comment:1 ocean904 years ago

  • Milestone changed from Unassigned to Future Release

I think there is a typo in your patch, you have commented $comment out.

comment:2 mrmist4 years ago

Think that's ok.. $comment is already set by that stage. Not sure why I left the comment in... Rush job.

comment:3 avryl8 months ago

  • Component changed from General to Comments
Note: See TracTickets for help on using tickets.