comments_popup_link() returns incorrect URI when there are zero comments [patch]

[matthewc]

When popup comments are disabled, the function comments_popup_link() echos the URI permalink#comments even when there are no comments present. In the default template the heading with the id #comments does not exist on the page until the first comment has been submitted. When there are zero comments, comments_popup_link() should echo permalink#respond instead.

My fix for this is as follows:

In comment-functions.php, replace line 121...

comments_link();

with the following...

if (0 == $number) {
  echo get_permalink() . '#respond';
} else {
  comments_link();
}

[Kafkaesqui]

This problem exists in the non-popup default comments template as well.

[markjaquith]

Sounds good to me. I made a patch for 1.5 branch

[markjaquith]

patch for 1.6 SVN

[matt]

(In [2685]) Indentation and correct response link when no comments, fixes #1408