WordPress.org

Make WordPress Core

Opened 5 years ago

Closed 5 years ago

#14107 closed defect (bug) (fixed)

Upgrade and Update interchangeable?

Reported by: RanYanivHartstein Owned by:
Milestone: 3.1 Priority: lowest
Severity: trivial Version:
Component: UI Keywords: has-patch
Focuses: Cc:

Description

In 3.0, upgrade and update are used seemingly interchangeably, for themes, plugins and core. This can lead to unnecessary confusion - in some cases, the two terms are used to describe the same thing.

In #4868, it's stated that "update" should generally be used to refer to "new versions". This was, apparently, to differentiate between *updating* to a new version and then *upgrading* the database.

However, this is no longer "enforced" in 3.0.

For example, for plugins and themes, I might see "3 upgrades available", but when I want to run the update/upgrade, I need to click "Update Plugins". After that, I may get this error: "Plugin upgrade failed".

This is just a quick example to demonstrate the issue. There are more instances of upgrade/update across the UI. I can give a more detailed list or just provide a patch.

My suggestion is to revisit the original conclusion of #4868, and decide again which term should be used when updating/upgrading either core, plugins or themes.

Personally, I vote for "upgrade":

Most users won't understand the difference between updating their files and upgrading the DB schema (which is probably one of the reasons automatic update was added in the first place). The way developers treat it in the code shouldn't necessarily be reflected in the UI. To users, it would make more sense to treat these two actions as two stages in the upgrade process, instead of two separate processes.

This thinking can inform other changes in the upgrade process, or just lead to a more uniform use of upgrade/update. Either way, the current state of things is confusing.

Attachments (1)

upgrade-update.diff (21.2 KB) - added by latz 5 years ago.

Download all attachments as: .zip

Change History (9)

comment:1 @johnbillion5 years ago

  • Cc johnbillion@… added

comment:2 follow-up: @nacin5 years ago

  • Milestone changed from Awaiting Review to 3.1
  • Priority changed from normal to lowest
  • Severity changed from normal to trivial

We should be standardizing on the word 'update'.

comment:3 in reply to: ↑ 2 @latz5 years ago

Should only be the output be standardized to "update" or even all file, class, variable, function, and method names in the source code?

@latz5 years ago

comment:4 @latz5 years ago

The above patch changes all output strings containing "upgrade" to "update".

comment:5 @latz5 years ago

  • Keywords has-patch added

comment:6 @markjaquith5 years ago

  • Resolution set to fixed
  • Status changed from new to closed

(In [16696]) Standardize around "Update" instead of "Upgrade." props RanYanivHartstein. props latz. fixes #14107

comment:7 @SergeyBiryukov5 years ago

  • Resolution fixed deleted
  • Status changed from closed to reopened

There's a misprint in wp-admin/upgrade.php on line 68: “You cannot udate”.

comment:8 @nacin5 years ago

  • Resolution set to fixed
  • Status changed from reopened to closed

(In [16823]) Fix typo. props SergeyBiryukov, fixes #14107.

Note: See TracTickets for help on using tickets.