WordPress.org

Make WordPress Core

Opened 6 years ago

Closed 2 years ago

Last modified 21 months ago

#14110 closed enhancement (wontfix)

Expose height and width attributes to 'wp_get_attachment_image_attributes' filter

Reported by: divinenephron Owned by:
Milestone: Priority: normal
Severity: minor Version: 3.0
Component: Media Keywords: reporter-feedback
Focuses: Cc:

Description

The filter 'wp_get_attachment_image_attributes' allows you to alter the attributes of embedded images. However the height and width attributes aren't passed to this filter. These would be useful to have – I'm making a theme with a fluid layout where I have to remove all height and width attributes to ensure that the browser maintains the attribute of images when they're resized.

I've attached a patch with a fix. In it I've also changed the function 'get_image_tag' so that I could remove the immensely pointless 'hwstring' function.

Attachments (4)

wp_get_attachment_image.diff (3.4 KB) - added by divinenephron 6 years ago.
Patch to give the 'wp_get_attachment_image_attributes' filter access to the heigh and width attribues.
wp_get_attachment_image_shortened.diff (1.1 KB) - added by divinenephron 6 years ago.
Only the changed that are essential to the enhancement.
wp_get_attachment_image.2.diff (4.1 KB) - added by Sam_a 5 years ago.
Let plugins filter image dimensions via wp_get_attachment_image_attributes filter (*props divinenephron*). Restore image dimensions if they're missing after applying the filter (consistent with the wp_get_attachment_image()'s previous behavior). Pass $icon to the filter too. Move esc_attr closer to output. Update documentation. Whitespace.
wp_get_attachment_image.3.diff (4.1 KB) - added by wpsmith 4 years ago.
Minor modification to lines 695-6, restore null as empty strings

Download all attachments as: .zip

Change History (22)

@divinenephron
6 years ago

Patch to give the 'wp_get_attachment_image_attributes' filter access to the heigh and width attribues.

#1 @divinenephron
6 years ago

  • Keywords has-patch added

#2 @nacin
6 years ago

  • Keywords has-patch filter wp_get_attachment_image_attributes attribute height width attachment removed

I see no reason to move around so much code for such a simple request.

@divinenephron
6 years ago

Only the changed that are essential to the enhancement.

#3 @divinenephron
6 years ago

  • Cc divinenephron added
  • Component changed from Plugins to Media
  • Keywords has-patch filter wp_get_attachment_image_attributes attribute height width attachment added
  • Severity changed from normal to minor

Evidently it's rude to refactor code in an enhancement request – sorry about that.
I've attached "wp_get_attachment_image_shortened.diff" – a file that contains only the changes that are essential to the enhancement. Is that more acceptable.

#4 @nacin
6 years ago

  • Keywords filter wp_get_attachment_image_attributes attribute height width attachment removed
  • Milestone changed from Awaiting Review to 3.1

Sorry, wasn't trying to be rude. It's just really hard to see what's going on when there's a ton of unrelated red and green.

This code looks fine, aside from the coding whitespace. (We use tabs, not spaces.)

#5 follow-ups: @nacin
6 years ago

  • Keywords 2nd-opinion added
  • Milestone changed from 3.1 to Future Release

I think this has the potential to break the filter, for those who receive an array through wp_get_attachment_image_attributes and build their own, not expecting additional keys.

#6 @scottconnerly
5 years ago

  • Cc scottconnerly added

I too would like to be able to access the image's height/width information from within the wp_get_attachment_image_attributes filter.

#7 @Sam_a
5 years ago

+1. When I added the wp_get_attachment_image_attributes hook (#8732), I omitted the height and width attributes because wp_get_attachment_image() had used image_hwstring() to format those. But it really doesn't make any sense that they're left out.

I think image_hwstring() is called only by wp_get_attachment_image_attributes().

Version 0, edited 5 years ago by Sam_a (next)

#8 in reply to: ↑ 5 @Sam_a
5 years ago

Replying to nacin:

I think this has the potential to break the filter, for those who receive an array through wp_get_attachment_image_attributes and build their own, not expecting additional keys.

That's true. I wonder how common that is.

@Sam_a
5 years ago

Let plugins filter image dimensions via wp_get_attachment_image_attributes filter (*props divinenephron*). Restore image dimensions if they're missing after applying the filter (consistent with the wp_get_attachment_image()'s previous behavior). Pass $icon to the filter too. Move esc_attr closer to output. Update documentation. Whitespace.

#9 in reply to: ↑ 5 @Sam_a
5 years ago

Replying to nacin:

I think this has the potential to break the filter, for those who receive an array through wp_get_attachment_image_attributes and build their own, not expecting additional keys.

Attached wp_get_attachment_image.2.diff should cover that.

Patch may look bigger than it is. ;)

@wpsmith
4 years ago

Minor modification to lines 695-6, restore null as empty strings

#10 @wpsmith
4 years ago

Wouldn't it make more sense to "restore" height/width ($attr['width']/$attr['height']) attributes as empty strings rather than their full value?

Last edited 4 years ago by wpsmith (previous) (diff)

#11 @Sam_a
4 years ago

Hi wpsmith,

Under WordPress's current behavior, the width and height attributes don't go through the wp_get_attachment_image_attributes filter, so a plugin that builds its own $attr array and returns it without width and height doesn't actually intend to remove them (as nacin noted in #5).

So if we also expose width and height in the filter, we want to continue that behavior — if the width and height keys are missing after applying the filter, restore them to their original values, as if they hadn't been removed.

Plugins that really want to empty width and height can set them to '' or false through the filter to get that.

#12 @anatolbroder
4 years ago

  • Cc anatol@… added

#13 @anatolbroder
4 years ago

Maybe you should combine the functions get_attachment_image and get_image_tag. They try to do similar things, but are both not flexible enough for using in plugins.

We need one low level function lowlevel_image for just creating an image tag from an attribute array.

<img
    alt='Image'
    class='image'
    data-image='{JSON}'
    height='456'
    id='123'
    src='image.png'
    title='Image'
    width='789'
    …
/>

And we need a high level function highlevel_image for own attachment images. The highlevel_image should collect the attributes from image meta an pass them to the lowlevel_image.

This ticket was mentioned in IRC in #wordpress-dev by SergeyBiryukov. View the logs.


2 years ago

#15 @ericlewis
2 years ago

  • Keywords reporter-feedback added; has-patch 2nd-opinion removed
  1. Why were we setting the image width/height attributes to begin with?
  1. Why would you need to override this for responsive design? max-width: 100% (or something like it) doesn't suffice?

#16 @wonderboymusic
2 years ago

  • Milestone Future Release deleted
  • Resolution set to wontfix
  • Status changed from new to closed

No reporter feedback in 4 months.

#17 @SergeyBiryukov
21 months ago

#30525 was marked as a duplicate.

#18 @hereswhatidid
21 months ago

+1. Is this being closed simply due to lack of feedback?

Note: See TracTickets for help on using tickets.