WordPress.org

Make WordPress Core

Opened 4 years ago

Closed 3 years ago

#14121 closed defect (bug) (fixed)

upload_space_check_disabled in upload_is_user_over_quota()

Reported by: SergeyBiryukov Owned by:
Milestone: 3.1 Priority: normal
Severity: normal Version: 3.0
Component: Multisite Keywords: has-patch commit
Focuses: Cc:

Description

wp-includes/ms-functions.php, line 1106:

function upload_is_user_over_quota( $echo = true ) {
	if ( get_site_option( 'upload_space_check_disabled' ) )
		return true;
	...
}

I guess it's hard to exceed space quota when upload space check is disabled :) So we should return false.

It seems the control never gets there in this case, though.

Attachments (1)

fix_upload_is_user_over_quota_when_space_check_is_disabled.patch (445 bytes) - added by SergeyBiryukov 4 years ago.

Download all attachments as: .zip

Change History (3)

comment:1 nacin3 years ago

  • Keywords commit added
  • Milestone changed from Awaiting Review to 3.1

comment:2 ryan3 years ago

  • Resolution set to fixed
  • Status changed from new to closed

(In [16299]) Return false if upload_space_check_disabled is true in upload_is_user_over_quota(). Props SergeyBiryukov. fixes #14121

Note: See TracTickets for help on using tickets.