WordPress.org
Get WordPress

Make WordPress Core

Opened 16 years ago

Last modified 11 months ago

#14125 reopened enhancement

Seperate out non-editable options in edit site

Reported by: wpmuguru Owned by: sorich87
Priority: normal Milestone:
Component: Options, Meta APIs Version:
Severity: normal Keywords: has-patch dev-feedback
Cc: Focuses: ui, multisite

Description

In the edit site screen, blog options which are arrays are shown as SERIALIZED and the textbox is disabled. The attached patch pulls those options out of the options metabox and displays the option name in another metabox below.

Related: #14120

Attachments (2)

14125.diff​ (1.7 KB ) - added by wpmuguru 16 years ago.
14125.2.diff​ (1.5 KB ) - added by sorich87 16 years ago.

Download all attachments as: .zip

Change History (14)

@wpmuguru
16 years ago

#1 follow-up: @wpmuguru
16 years ago

I think this patch also fixes #14120.

#2 in reply to: ↑ 1 @wpmuguru
16 years ago

Replying to wpmuguru:

I think this patch also fixes #14120.

I found another upgrade MU blog to check & this wouldn't fix #14120 because in MU allowed themes was blank by default and isn't in shown as serialized.

#3 follow-up: @nacin
16 years ago

  • Keywords needs-refresh added; has-patch removed
  • Milestone Awaiting Review → 3.1

This looks good in terms of cleaning up that page more. Needs refresh though due to the network admin.

@sorich87
16 years ago

#4 in reply to: ↑ 3 @sorich87
16 years ago

  • Keywords has-patch 2nd-opinion added; needs-refresh removed
  • Owner set to sorich87
  • Status new → accepted

Replying to nacin:

This looks good in terms of cleaning up that page more. Needs refresh though due to the network admin.

New patch. I was not sure about the look of the new non-editable options table.

#5 @jane
16 years ago

Pete Mall should take a look since he's all over the network admin.

#6 @PeteMall
16 years ago

  • Milestone 3.1 → Future Release

I'm not sure on the best way to separate out the serialized data yet. Punting for now.

#7 @jeremyfelt
12 years ago

  • Component Multisite → Options and Meta
  • Focuses ui multisite added

#8 @cfoellmann
12 years ago

Maybe it is worth looking at this ​https://github.com/leeoniya/dump_r.php, ​http://krumo.sourceforge.net/ and/or ​http://raveren.github.io/kint/.
This could be used to at least provide a non-editable display of the value

Last edited 12 years ago by cfoellmann (previous) (diff)

#9 @chriscct7
11 years ago

  • Keywords dev-feedback added; 2nd-opinion removed

#10 @SirLouen
12 months ago

  • Resolution → maybelater
  • Status accepted → closed

Sorry for this, I'm testing a thing.

#11 @SirLouen
12 months ago

  • Resolution maybelater
  • Status closed → reopened

Second and last part of the test

#12 @johnjamesjacoby
11 months ago

I don't mind this.

We should do this same thing in options.php for all sites.

Note: See TracTickets for help on using tickets.