WordPress.org

Make WordPress Core

Opened 6 years ago

Last modified 4 months ago

#14125 accepted enhancement

Seperate out non-editable options in edit site

Reported by: wpmuguru Owned by: sorich87
Milestone: Future Release Priority: normal
Severity: normal Version:
Component: Options, Meta APIs Keywords: has-patch dev-feedback
Focuses: ui, multisite Cc:

Description

In the edit site screen, blog options which are arrays are shown as SERIALIZED and the textbox is disabled. The attached patch pulls those options out of the options metabox and displays the option name in another metabox below.

Related: #14120

Attachments (2)

14125.diff (1.7 KB) - added by wpmuguru 6 years ago.
14125.2.diff (1.5 KB) - added by sorich87 5 years ago.

Download all attachments as: .zip

Change History (11)

@wpmuguru
6 years ago

#1 follow-up: @wpmuguru
6 years ago

I think this patch also fixes #14120.

#2 in reply to: ↑ 1 @wpmuguru
6 years ago

Replying to wpmuguru:

I think this patch also fixes #14120.

I found another upgrade MU blog to check & this wouldn't fix #14120 because in MU allowed themes was blank by default and isn't in shown as serialized.

#3 follow-up: @nacin
5 years ago

  • Keywords needs-refresh added; has-patch removed
  • Milestone changed from Awaiting Review to 3.1

This looks good in terms of cleaning up that page more. Needs refresh though due to the network admin.

@sorich87
5 years ago

#4 in reply to: ↑ 3 @sorich87
5 years ago

  • Keywords has-patch 2nd-opinion added; needs-refresh removed
  • Owner set to sorich87
  • Status changed from new to accepted

Replying to nacin:

This looks good in terms of cleaning up that page more. Needs refresh though due to the network admin.

New patch. I was not sure about the look of the new non-editable options table.

#5 @jane
5 years ago

Pete Mall should take a look since he's all over the network admin.

#6 @PeteMall
5 years ago

  • Milestone changed from 3.1 to Future Release

I'm not sure on the best way to separate out the serialized data yet. Punting for now.

#7 @jeremyfelt
2 years ago

  • Component changed from Multisite to Options and Meta
  • Focuses ui multisite added

#8 @cfoellmann
2 years ago

Maybe it is worth looking at this https://github.com/leeoniya/dump_r.php, http://krumo.sourceforge.net/ and/or http://raveren.github.io/kint/.
This could be used to at least provide a non-editable display of the value

Last edited 2 years ago by cfoellmann (previous) (diff)

#9 @chriscct7
4 months ago

  • Keywords dev-feedback added; 2nd-opinion removed
Note: See TracTickets for help on using tickets.