edit_posts_per_page

[tslice]

Looks like a filter name was changed for edit_posts_per_page. A workaround has been to hook into both: edit_posts_per_page && edit_post_per_page (note the missing or added 's').

[wpmuguru]

The reporter is referring to the @todo on line 51 of wp-admin/edit.php. Around line 900 of wp-admin/includes/post.php is the edit_ . $post_type . _per_page.

[wpmuguru]

The patch also fixes #14342. The affected code was all added in 3.0, so both should be fine under 3.0.1.

[wpmuguru]

The second patch uses the 20 in [15444] and less confusing variable names.

Anyone using these filters would have been using both filters to get the correct display, so switching to using the same filter should not adversely affect anyone.

[nacin]

I don't see why the filter needs to be removed? That's a generic filter and should remain if only for back compat. Possibly even added into template.php I'd think.

[wpmuguru]

It was added in 3.0, so it's only covering backward compatibility for 33 days. Anyone using it will also have to use the other filter as well or the page count is off.

Do you want me to redo the patch & put the generic one back and add it to includes/post.php?

[nacin]

​http://core.trac.wordpress.org/browser/branches/2.9/wp-admin/includes/post.php#L853

It used to be edit_posts_per_page. We changed it in wp-admin/includes, but didn't change this instance. Really, both spots should have both filters, generic (old) followed by specific (new). Unless I'm missing something -- does that make sense?

[wpmuguru]

Added. I also added the post_type to the generic filter.

Even without your explanation above, in the 3.0 cycle we added quite a few of the generic filters because they are useful. So, the generic one should remain here for consistency.

[nacin]

Looks solid.

[nacin]

Out of curiosity, anyone else have a preference for which filter comes first?

[wpmuguru]

(Now that I looked...) In _option & _transient functions they are the opposite order- specific first, generic second. We should go for consistency.

[wpmuguru]

I swapped those lines and found I had used the wrong var in includes/post.php.

[ryan]

(In [15450]) Make posts per page filters consistent and back compat. Props wpmuguru. fixes #14135 for 3.1

[ryan]

(In [15451]) Make posts per page filters consistent and back compat. Props wpmuguru. fixes #14135 for 3.0.1

[nacin]

We forgot about edit_pages_per_page. Do we care?

[sorich87]

The previous changeset did not take into account 'wp-admin/includes/template.php'. The generic filter was not added in this file.

I don't think 'edit_pages_per_page' is necessary, since 'edit_posts_per_page' accepts the post type as parameter.

[hakre]

Replying to sorich87:

I don't think 'edit_pages_per_page' is necessary, since 'edit_posts_per_page'
accepts the post type as parameter.

good point

[nacin]

That's not the point though, edit_pages_per_page was in 2.9, and now it's not in 3.0.

[sorich87]

Refreshed patch, with edit_pages_per_page

[ryan]

At this late stage, the new way is established. There's little point in adding legacy filters.

[sorich87]

Even if we don't want to add the legacy filter 'edit_pages_per_page', the original issue still remains:

The use of the filter 'edit_posts_per_page' is not consistent. That filter should be applied not only to the posts query, but also to the screen options.
Actually, when you use the filter to set the number of posts, the screen option doesn't show your value set via the filter but the default value. There is no consistency between the actual number of posts displayed and the number shown in the screen options.

[sorich87]

Fixes consistency of 'edit_posts_per_page'

[ryan]

Or remove the two occurrences of edit_posts_per_page.

[sorich87]

Removes 'edit_posts_per_page'

[ryan]

After IRC discussion, going with 14135.6.diff.

[ryan]

(In [17082]) Consistently use edit_posts_per_page. Props sorich87. fixes #14135