WordPress.org

Make WordPress Core

Opened 4 years ago

Closed 3 years ago

Last modified 14 months ago

#14140 closed enhancement (fixed)

Wrap URL for password reset in angle brackets

Reported by: demetris Owned by:
Milestone: 3.1 Priority: normal
Severity: normal Version: 3.0
Component: Mail Keywords: has-patch
Focuses: Cc:

Description

Some email clients do not handle well URLs that wrap across lines; that is, they fail to make them clickable in their entirety.

This can confuse WP users who are emailed a URL to reset their passwords, because clicking does not lead to a valid URL. See this wp-hackers thread:

http://groups.google.com/group/wp-hackers/t/155a6011e3a835a2

Core could fix this for several (most? all?) problematic email clients by simply enclosing the URL in angle brackets (the less than and greater than signs) before sending it.

I attach a tentative patch to get us going.

See also a couple of mentions/recommendations of the angle brackets as delimiters for URIs in plain text:

http://www.w3.org/Addressing/URL/5.1_Wrappers.html

http://www.ietf.org/rfc/rfc3986.txt (go to Appendix C)

Attachments (1)

t14140-url-angle-brackets.diff (769 bytes) - added by demetris 4 years ago.
Encloses URL for password reset in angle brackets

Download all attachments as: .zip

Change History (5)

demetris4 years ago

Encloses URL for password reset in angle brackets

comment:1 nacin4 years ago

  • Component changed from General to Mail
  • Keywords dev-feedback removed
  • Milestone changed from Awaiting Review to 3.1

Agreed with westi on this (as said over wp-hackers). I imagine there are other instances where < > would be useful, but this is a start.

comment:2 azizur4 years ago

  • Cc prodevstudio+wordpress@… added

comment:3 westi3 years ago

  • Resolution set to fixed
  • Status changed from new to closed

(In [16285]) Wrap the reset link in <> so as to protect it when it goes over multiple lines in an email client. Fixes #14140 props demetris.

comment:4 iandunn14 months ago

  • Cc ian_dunn@… added

This causes the URL to be parsed as HTML (and therefore not displayed) when the content-type is "text/html". See #23578.

Last edited 14 months ago by iandunn (previous) (diff)
Note: See TracTickets for help on using tickets.