WordPress.org

Make WordPress Core

Opened 5 years ago

Closed 4 years ago

#14147 closed defect (bug) (fixed)

mysql2date uses spaces instead of tabs

Reported by: jorbin Owned by:
Milestone: 3.1 Priority: high
Severity: normal Version:
Component: Inline Docs Keywords: needs-refresh
Focuses: Cc:

Description

For the love of all that is holy. Tabs, baby, tabs.

Attachments (6)

tabs.patch (443 bytes) - added by jorbin 5 years ago.
tabs.2.patch (499 bytes) - added by jorbin 5 years ago.
14147.diff (3.6 KB) - added by jacobsantos 5 years ago.
Update more coding standard violations.
i-like-tabs-alot.patch (9.8 KB) - added by Viper007Bond 5 years ago.
Everything in the root of wp-includes that aren't existing classes :)
14147.patch (3.9 KB) - added by Viper007Bond 5 years ago.
I still like tabs alot
14147.2.diff (4.0 KB) - added by sorich87 4 years ago.
Tabs to save kittehs.

Download all attachments as: .zip

Change History (19)

@jorbin5 years ago

comment:1 @Viper007Bond5 years ago

More important patch in history as this will save my sanity (it drives me nuts every time I open the file, haha).

comment:2 @PeteMall5 years ago

I hate to see alot of spaces... Tabs save kittehs!

comment:3 @nacin5 years ago

  • Component changed from Formatting to Inline Docs
  • Keywords needs-patch added; has-patch removed
  • Milestone changed from Awaiting Review to 3.1
  • Priority changed from normal to high

Worse, there's a space to the left of $translate, but not to the right.

Upping priority. :-)

@jorbin5 years ago

comment:4 @jorbin5 years ago

  • Keywords has-patch added; needs-patch removed

@nacin - Are you sure this isn't Highest OMG BBQ?

Tabs, baby, Tabs!

comment:5 @dd325 years ago

  • Resolution set to fixed
  • Status changed from new to closed

(In [15353]) Tabs are so much nicer than spaces.. Props jorbin. Fixes #14147

comment:6 @dd325 years ago

(In [15354]) And the rest of r15353. See #14147

comment:7 @dd325 years ago

  • Resolution fixed deleted
  • Status changed from closed to reopened

@jacobsantos5 years ago

Update more coding standard violations.

@Viper007Bond5 years ago

Everything in the root of wp-includes that aren't existing classes :)

comment:8 @dd325 years ago

(In [15355]) Alot more tabs. Props jacobsantos & Viper007bond. See #14147

comment:9 @dd325 years ago

  • Resolution set to fixed
  • Status changed from reopened to closed

@Viper007Bond5 years ago

I still like tabs alot

comment:10 @Viper007Bond5 years ago

  • Resolution fixed deleted
  • Status changed from closed to reopened

I still like tabs alot

comment:11 @nacin4 years ago

  • Keywords needs-refresh added; has-patch removed

I like tabs alot too, but this patch no longer applies.

@sorich874 years ago

Tabs to save kittehs.

comment:12 @ryan4 years ago

(In [16306]) Whitespace cleanup. Props sorich87. see #14147

comment:13 @ryan4 years ago

  • Resolution set to fixed
  • Status changed from reopened to closed
Note: See TracTickets for help on using tickets.