Option to use name, in additon to slug and id in get_term_link() function

[sudar]

Right now the get_term_link() function (in wp-includes/taxonomy.php) can be used only with either term id or term slug.

It would be useful to provide an option to add name in addition to term id and slug.

This function inturn uses get_term_by() function and it has the option to provide term name, but the get_term_link() function doesn't have a way to do this.

[sudar]

Path which adds the third parameter to get_term_link function

[scribu]

+1 on the idea.

[scribu]

On the other hand, while I agree that:

get_term_link( 'Term Name', 'taxname', 'name' )

looks better than:

get_term_link( get_term_by( 'name', 'Term Name', 'taxname' ), 'taxname' )

, it's just an implementation detail. get_term_link() shouldn't be concerned with retrieving the correct term.

To avoid passing the taxonomy over and over again, it would be nice if you could do something like this instead:

get_term_by( 'name', 'Term Name', 'taxname' )->get_link()

[scribu]

Related: #14162.

[scribu]

Related: #13081.

[markjaquith]

To late for enhancements for 3.1.

[mordauk]

14156.patch refreshes the patch.

14156-tests.patch adds unit tests.

[boonebgorges]

In 32552:

Unit tests for get_term_link().

See #14156.

[boonebgorges]

In 32553:

Introduced $field argument to get_term_link().

This new argument allows developers to specify which term field should be
matched by the value of the $term parameter (in particular, 'name' and
'term_taxonomy_id' are now supported).

Props sudar, mordauk.
Fixes #14156.

[johnbillion]

I'm a little concerned that this introduces yet more inconsistency with regard to which term functions accept which values for their $term argument. This is now the only term function apart from get_term_by() which accepts a $field argument.

Should we add the $field parameter to get_term_feed_link(), get_edit_term_link() or other term functions too?

[sudar]

Replying to johnbillion:

Should we add the $field parameter to get_term_feed_link(), get_edit_term_link() or other term functions too?

I can send a new patch for this with $field parameter for both the functions if we decided to do it.

[helen]

I'm leaning toward reverting this - I'm not completely sure in what scenario you only have the term name available to you, and doing a get_term_by() first yourself is more correct than mixing this into get_term_link() IMO. I'd way rather get on a WP_Term object, see #14162 for that.

[boonebgorges]

I don't feel strongly about it. I agree that it introduces some inconsistency in function interfaces, and I agree that the workaround (looking up a term with get_term_by() before fetching the term link) is far from onerous. Let's revert.

[boonebgorges]

In 33022:

Don't allow $field param to be passed to get_term_link().

The new parameter creates inconsistencies in the signatures of the various
functions for fetching term links (get_term_feed_link(),
get_edit_term_link(), etc.).

Reverts [32553].

See #14156.