WordPress.org

Make WordPress Core

Changes between Version 2 and Version 3 of Ticket #14179, comment 39


Ignore:
Timestamp:
07/21/2017 08:16:19 PM (3 years ago)
Author:
dingdang
Comment:

Legend:

Unmodified
Added
Removed
Modified
  • Ticket #14179, comment 39

    v2 v3  
    1717- the API gets a request to update a theme with UID abc|gfkshjg41765jg2j53nghg3ghf76323
    1818- it checks against the list of native themes' UIDs and it '''founds it''' (as it is an old version from the SVN) and continues (as in the workflow I described in the proposal) otherwise it would stop here
    19 - it extracts the actual theme slug which is "abc" just from the UID (getting the part before the delimiter)
     19- it extracts the actual theme slug which is "abc" just from the UID (getting the part that precedes the delimiter)
    2020- continue with the algorithm and return back to the site a reply with the current version of the theme "abc"
    2121Voila!
     
    3030- there are a total of N*1.56 UIDs (that's because some themes have "evolved" and got changed author or (in most of the cases) the author URI). I've got that real 1.56 coefficient from the partial download I've done of about 1400 themes that I've downloaded all versions of (about 16000 in total)
    3131- so 1 theme is identified in general by more than one UID of the new type
    32 - any site with any of these UIDs is unambiguously linked by the API to specific theme slug (the part before the delimiter) and the API sends back the new version as usual (there is no changes in this part of the code at all)
     32- any site with any of these UIDs is unambiguously linked by the API to specific theme slug (the part that precedes the delimiter) and the API sends back the new version as usual (there is no changes in this part of the code at all)
    3333- any external theme with the same name however comes with different UID and so the API stops at that point where this UID is unknown (not present in the table of UIDs) and so doesn't send back an update info, nor counts this as active install.
    3434