WordPress.org
Get WordPress

Make WordPress Core

Opened 16 years ago

Closed 16 years ago

Last modified 16 years ago

#14182 closed defect (bug) (fixed)

Plugin Upgrade doesnt delete previous directory if it differs from the upgrade directory

Reported by: hakre Owned by:
Priority: normal Milestone: 3.2
Component: Upgrade/Install Version:
Severity: normal Keywords:
Cc: Focuses:

Description (last modified by dd32)

If some plugins are residing in their own directory and the auto-update is run, the updater installs the update into another directory.

This leaves two plugins in the same install afterwards. Looks like the updater is not taking the current plugin directory into account.

Change History (11)

#1 @hakre
16 years ago

Related: #14179

Related: #13928

#2 @hakre
16 years ago

Related: #11495

#3 @hakre
16 years ago

Errata: First "directory" in ticket's Description must be "plugin".

#4 @dd32
16 years ago

  • Description modified (diff)

Correct, The plugin upgrader has -always- installed into a directory based on the .org slug, Thats by design.

The plugin should still be deleted however, even if its in a different named folder.

#5 @dd32
16 years ago

  • Component General → Upgrade/Install
  • Milestone Awaiting Review → 3.1
  • Summary Plugins Upgraded into wrong directory → Plugin Upgrade doesnt delete previous directory if it differs from the upgrade directory

Confirmed that its not deleting the plugin in 3.0.

#6 @dd32
16 years ago

  • Keywords needs-patch added

Was working in 2.8, Broke in 2.9.

#7 @jane
16 years ago

If anyone's planning to patch this for 3.1, please post what you've got so people can help move it forward before we hit freeze for this release.

#8 @nacin
16 years ago

  • Milestone 3.1 → Future Release

No patch.

#9 @dd32
16 years ago

  • Keywords needs-patch removed
  • Milestone Future Release → 3.2

traced this back to this commit: [11926] Plugin/Theme installer: Do not bail if empty destination directory exists, props dd32, fixes #10775

The changes made resulted in the filter only running when the destination exists (Which in this case, it doesn't)

#10 @dd32
16 years ago

  • Resolution → fixed
  • Status new → closed

(In [17590]) When upgrading plugins|themes, if the new destination folder is different from the previous folder, delete the old folder upon upgrade. Fixes #14182

#11 @dd32
16 years ago

(In [17591]) Remove debug cruft from [17590]. See #14182

Note: See TracTickets for help on using tickets.