WordPress.org

Make WordPress Core

Opened 5 years ago

Closed 4 years ago

#14187 closed defect (bug) (fixed)

strrpos supports only a single character for the needle in PHP4

Reported by: mailnew2ster Owned by:
Milestone: 3.1 Priority: normal
Severity: normal Version:
Component: HTTP API Keywords: has-patch needs-testing
Focuses: Cc:

Description

class-http.php, line 1411:
http://core.trac.wordpress.org/browser/trunk/wp-includes/class-http.php#L1411

strrpos is used, while it does not work as expected on PHP4. Can be replaced by strpos, as the position is not needed in that case.

Attachments (1)

.diff (450 bytes) - added by mailnew2ster 5 years ago.

Download all attachments as: .zip

Change History (4)

@mailnew2ster5 years ago

comment:1 @dd325 years ago

  • Keywords has-patch needs-testing added

From what i can see, Changing from looking for the last occurrence, to the first occurrence as in the patch wouldnt cause an issue..

comment:2 @nacin5 years ago

  • Milestone changed from Awaiting Review to 3.1

comment:3 @nacin4 years ago

  • Resolution set to fixed
  • Status changed from new to closed

(In [16762]) We only need strpos here. Ensures PHP4 compat. props mailnew2ster, fixes #14187.

Note: See TracTickets for help on using tickets.