Quick Edit Parentage

[filosofo]

If you change a page's page via quick edit, the page item stays below its current parent.

It seems to me that it ought to move underneath the new parent or disappear if that parent is not on the current page.

[solarissmoke]

Patch checks if an edited page has a new parent and moves the row underneath that one. If the parent doesn't exist on this page then it hides the row altogether.

The AJAX response does not include —es to indicate that the page is a child of another - which makes sense with the current functionality because the child page isn't in the right place anyway. Fixing this is going to be a bit messy though.

[DrewAPicture]

#19529 closed as duplicate.

Related: #19474

[SergeyBiryukov]

Related: #18615

[MikeHansenMe]

This problem still exists in 3.5-beta-1.

[MikeHansenMe]

Updated diff to patch the correct file and confirmed it is working as expected.

[MikeHansenMe]

same patch with new path

[MikeHansenMe]

Patch still applies clean.

[DrewAPicture]

edit: my bad. Looks good, let's do this early 3.7.

[wonderboymusic]

these are all marked 3.7-early

[wonderboymusic]

@DrewAPicture + @MikeHansenMe, can someone look at this and determine if all is still well?

[DrewAPicture]

Replying to wonderboymusic:

@DrewAPicture + @MikeHansenMe, can someone look at this and determine if all is still well?

14188.2.diff​ still works great for me.

[wonderboymusic]

In 25663:

When Quick Edit'ing a page, checks if edited page has a new parent and moves the row underneath that one. If the parent doesn't exist on this page then it hides the row altogether.

Props solarissmoke, MikeHansenMe.
Fixes #14188.

[nacin]

If the parent doesn't exist on this page then it hides the row altogether.

Hmm. I'd argue this is actually pretty unexpected and jarring behavior.

[nacin]

[25667] reverted [25663]. See ​http://irclogs.wordpress.org/chanlog.php?channel=wordpress-dev&day=2013-10-02&sort=asc#m699976.

[adamsilverstein]

fixes alternate row coloring when moving page to parent not on screen

[nacin]

Per IRC discussion, this was actually the proper fix, in that it moved it to be under the parent if it was on the same page, but did not remove it if it wasn't. It was the commit message that was off. Given there is another patch to adjust row coloring, let's regroup in 3.8.

[nacin]

Closing as fixed for 3.7, as alternate row coloring will likely be moved to CSS soon enough.