WordPress.org

Make WordPress Core

Opened 4 years ago

Closed 5 months ago

#14188 closed defect (bug) (fixed)

Quick Edit Parentage

Reported by: filosofo Owned by: filosofo
Milestone: 3.7 Priority: lowest
Severity: minor Version: 3.0
Component: Administration Keywords: has-patch 3.7-early commit
Focuses: Cc:

Description

If you change a page's page via quick edit, the page item stays below its current parent.

It seems to me that it ought to move underneath the new parent or disappear if that parent is not on the current page.

Attachments (3)

14188.diff (1.4 KB) - added by solarissmoke 3 years ago.
14188.2.diff (1.3 KB) - added by MikeHansenMe 18 months ago.
same patch with new path
14188.3.diff (1.3 KB) - added by adamsilverstein 7 months ago.
fixes alternate row coloring when moving page to parent not on screen

Download all attachments as: .zip

Change History (23)

comment:1 garyc403 years ago

  • Cc garyc40@… added

solarissmoke3 years ago

comment:2 solarissmoke3 years ago

  • Keywords has-patch dev-feedback added; needs-patch removed

Patch checks if an edited page has a new parent and moves the row underneath that one. If the parent doesn't exist on this page then it hides the row altogether.

The AJAX response does not include —es to indicate that the page is a child of another - which makes sense with the current functionality because the child page isn't in the right place anyway. Fixing this is going to be a bit messy though.

comment:3 DrewAPicture2 years ago

#19529 closed as duplicate.

Related: #19474

comment:5 MikeHansenMe19 months ago

  • Cc mdhansen@… added

This problem still exists in 3.5-beta-1.

comment:6 MikeHansenMe18 months ago

  • Cc mdhansen@… removed

Updated diff to patch the correct file and confirmed it is working as expected.

MikeHansenMe18 months ago

same patch with new path

comment:7 MikeHansenMe18 months ago

  • Cc mdhansen@… added

comment:8 MikeHansenMe10 months ago

Patch still applies clean.

comment:9 DrewAPicture10 months ago

  • Keywords 3.7-early added

edit: my bad. Looks good, let's do this early 3.7.

Last edited 10 months ago by DrewAPicture (previous) (diff)

comment:10 wonderboymusic9 months ago

  • Milestone changed from Future Release to 3.7

these are all marked 3.7-early

comment:11 follow-up: wonderboymusic7 months ago

@DrewAPicture + @MikeHansenMe, can someone look at this and determine if all is still well?

comment:12 in reply to: ↑ 11 DrewAPicture7 months ago

  • Keywords commit added; dev-feedback removed

Replying to wonderboymusic:

@DrewAPicture + @MikeHansenMe, can someone look at this and determine if all is still well?

14188.2.diff still works great for me.

comment:13 wonderboymusic7 months ago

  • Resolution set to fixed
  • Status changed from new to closed

In 25663:

When Quick Edit'ing a page, checks if edited page has a new parent and moves the row underneath that one. If the parent doesn't exist on this page then it hides the row altogether.

Props solarissmoke, MikeHansenMe.
Fixes #14188.

comment:14 nacin7 months ago

If the parent doesn't exist on this page then it hides the row altogether.

Hmm. I'd argue this is actually pretty unexpected and jarring behavior.

adamsilverstein7 months ago

fixes alternate row coloring when moving page to parent not on screen

comment:16 SergeyBiryukov7 months ago

  • Milestone changed from 3.7 to 3.8
  • Resolution fixed deleted
  • Status changed from closed to reopened

comment:17 nacin7 months ago

Per IRC discussion, this was actually the proper fix, in that it moved it to be under the parent if it was on the same page, but did not remove it if it wasn't. It was the commit message that was off. Given there is another patch to adjust row coloring, let's regroup in 3.8.

comment:18 adamsilverstein7 months ago

  • Cc adamsilverstein@… added

comment:19 matt5 months ago

  • Priority changed from normal to lowest
  • Severity changed from normal to minor

comment:20 nacin5 months ago

  • Milestone changed from 3.8 to 3.7
  • Resolution set to fixed
  • Status changed from reopened to closed

Closing as fixed for 3.7, as alternate row coloring will likely be moved to CSS soon enough.

Note: See TracTickets for help on using tickets.