streams.php, POMO_FileReader $length parameter of fread

[bueltge]

the fread function run with an error, when you have the length-paramter ist 0. This is possible on use WP in local engines and intranet.
Small changes on the function: read in class POMO_FileReader

	function read($bytes) {
		if ( isset($bytes) && ( 0 > $bytes ) )
			return fread($this->_f, $bytes);
		else
			return;
	}

[nacin]

Without speaking at all to the validity of the patch, checking for empty() would be much simpler.

Lowering priority a bit as fread() with zero length fires only a warning, not a fatal, and I'm still not sure of the steps to reproduce an instance where 0 is requested.

[bueltge]

the warning is an problem when you work with WP_DEBUG true; its not possible to use the backend. Yes, you can change this to empty().

[SergeyBiryukov]

What are the steps to reproduce this?

[Bueltge]

"the fread function run with an error, when you have the length-paramter ist 0. This is possible on use WP in local engines and intranet"
when the blog in a landscape without internet-connection

[SergeyBiryukov]

Still don't quite understand the connection between intranet and reading .mo files.

However I guess the condition in the patch should be inverted:

if ( !empty($bytes) )
	return fread($this->_f, $bytes);
else
	return false;

Uploaded new patch.

[bueltge]

I have check this on my development-version and now works fine, no errors for fread. Thanks

	function read($bytes) {
		if ( !empty($bytes) )
			return fread($this->_f, $bytes);
		else
			return false;
	}

[SergeyBiryukov]

Related: #14882

[nacin]

Perhaps the read() method should be avoided if ! $bytes?

[SergeyBiryukov]

read() method is only called for an arbitrary number of bytes in lines 160 and 169 of mo.php:
​http://core.trac.wordpress.org/browser/tags/3.3.1/wp-includes/pomo/mo.php#L160

14207.2.patch​ makes sure the values passed to read() are not zero.

I'm still not sure what are we trying to fix here though. I've checked a localized install without Internet access with WP_DEBUG on and didn't see any warnings.

[chriscct7]

Seems this is an impossible scenario to generate. Closing as worksforme.