WordPress.org

Make WordPress Core

Opened 7 years ago

Closed 7 years ago

#14208 closed defect (bug) (fixed)

by adding a custom menu with the url without the slash (/) the menu dont active in front page

Reported by: mati1000 Owned by: filosofo
Milestone: 3.1 Priority: normal
Severity: normal Version: 3.0
Component: Menus Keywords: has-patch commit
Focuses: Cc:

Description

(sorry of my english)

I add a custom menu in wp 3.0 with the url:

http://localhost/wordpress

and it dont get the "menu-item-home/current_page_item" classes.

I think it makes sense to compare olso the menu_url if it is the current address_url without the last slash

Attachments (1)

custom-menu-item-unslashed.14208.diff (1.1 KB) - added by filosofo 7 years ago.

Download all attachments as: .zip

Change History (10)

#1 follow-up: @filosofo
7 years ago

  • Keywords has-patch added
  • Milestone changed from Awaiting Review to 3.1

Please try the attached patch and see if that solves your problem.

#2 @filosofo
7 years ago

  • Owner set to filosofo
  • Status changed from new to accepted

#3 in reply to: ↑ 1 @mati1000
7 years ago

yes!! it solve! THANKS!

Replying to filosofo:

Please try the attached patch and see if that solves your problem.

#4 @mati1000
7 years ago

  • Resolution set to fixed
  • Status changed from accepted to closed

#5 follow-up: @filosofo
7 years ago

  • Resolution fixed deleted
  • Status changed from closed to reopened

mati1000, it's not considered "fixed" until the patch is actually committed to trunk.

#6 in reply to: ↑ 5 @mati1000
7 years ago

how I unfixed it?

Replying to filosofo:

mati1000, it's not considered "fixed" until the patch is actually committed to trunk.

#7 @filosofo
7 years ago

When (and if) someone with commit access to WordPress trunk applies the patch to the trunk code, then it becomes part of WordPress and this ticket can be marked as "fixed."

#8 @nacin
7 years ago

  • Keywords commit added

#9 @markjaquith
7 years ago

  • Resolution set to fixed
  • Status changed from reopened to closed

(In [15584]) When doing current page highlighting logic, apply untrailingslashit() to everything so that slash additions or omissions still match. fixes #14208. props filosofo

Note: See TracTickets for help on using tickets.