wp_login_form remember input / label mixed

[chocks]

On wp-includes/general-template.php line 284 it says:
' . ( $argsremember? ? '<p class="login-remember"><label><input name="rememberme" type="checkbox" id="' . esc_attr( $argsid_remember? ) . '" value="forever" tabindex="90"' . ( $argsvalue_remember? ? ' checked="checked"' : ) . ' /> ' . esc_html( $argslabel_remember? ) . '</label></p>' : ) . '

Should be:
' . ( $argsremember? ? '<p class="login-remember"><label>' . esc_html( $argslabel_remember? ) . '</label><input name="rememberme" type="checkbox" id="' . esc_attr( $argsid_remember? ) . '" value="forever" tabindex="90"' . ( $argsvalue_remember? ? ' checked="checked"' : ) . ' />
</p>' : ) . '

Where <p><label>$labelname</label> and <input /></p>

[wojtek.szkutnik]

Confirmed and fixed

[nacin]

What is this fixing?

It looks like all it is doing is switching the checkbox and the text.

Additionally the patch breaks the label association with the checkboxes. Labels either have to be linked to inputs with the 'for' attribute, or they need to wrap the input. (Which is why it wrapped it originally.)

[GamajoTech]

I'll second nacin's comments - there's no fixing here, just breaks.

@wojtek.szkutnik - it's fairly standard to have checkbox and radio inputs appear *before* the labels, unlike regular text/password/html5 variants inputs which tend to have their labels to the left or above.
(Although saying that, the CC feature of Trac does it the other way around I notice.)