WordPress.org

Make WordPress Core

Opened 4 years ago

Closed 4 years ago

Last modified 4 years ago

#14260 closed defect (bug) (invalid)

When No Category Is Attached To A Post In TwentyTen

Reported by: markmcwilliams Owned by:
Milestone: Priority: normal
Severity: normal Version: 3.0
Component: Themes Keywords: has-patch
Focuses: Cc:

Description

I was looking over at Andrew Nacin's site earlier and noticed at the end of the post it said "This entry was posted in and tagged my plugins, plugins, Simple Footnotes, WordPress." - Notice that because it's missing a category (I believe?) it kind of looks a little odd (has nothing there) ... so I started looking into the code, and well, came up with a patch (I hope!) that could fix it? I just don't have a local install, or a live install that I could test it on sadly''

Attachments (1)

14260.diff (1.3 KB) - added by markmcwilliams 4 years ago.
typo in the other patch

Download all attachments as: .zip

Change History (4)

markmcwilliams4 years ago

typo in the other patch

comment:1 markmcwilliams4 years ago

  • Keywords has-patch added

Added a stupid 9 in front of the opening <?php, sorted though! :)

comment:2 follow-up: nacin4 years ago

  • Milestone Awaiting Review deleted
  • Resolution set to invalid
  • Status changed from new to closed

My site has categories disabled higher up the stack, and I never updated some template overrides that were rendered moot by some reshuffling in Twenty Ten (I think by me, ironically) later in the 3.0 cycle.

A post must always have at least one category, the default category if nothing else. I think a lot of us would love to see it go, but that is an unfortunate reality for now because so many themes (including Twenty Ten, as you identified here) assume a post has at least one category. So, until we decide to change that across the board in a future release, I'm closing as invalid.

You may wish to file a bug report at http://trac.andrewnacin.com :-P

Side note -- you should definitely set up a local install. Well worth the effort especially for someone learning how to write PHP and hack WordPress.

comment:3 in reply to: ↑ 2 markmcwilliams4 years ago

Replying to nacin:

My site has categories disabled higher up the stack, and I never updated some template overrides that were rendered moot by some reshuffling in Twenty Ten (I think by me, ironically) later in the 3.0 cycle.

Oh I see, that'd explain all that then!

Replying to nacin:

A post must always have at least one category, the default category if nothing else. I think a lot of us would love to see it go, but that is an unfortunate reality for now because so many themes (including Twenty Ten, as you identified here) assume a post has at least one category. So, until we decide to change that across the board in a future release, I'm closing as invalid.

Fair enough, personally I'd like to see this an option in a future version, sometimes things just don't need a category, but that's best saved for a developer chat!

Replying to nacin:

You may wish to file a bug report at http://trac.andrewnacin.com :-P

I might just have to do that...? :D

Replying to nacin:

Side note -- you should definitely set up a local install. Well worth the effort especially for someone learning how to write PHP and hack WordPress.

I will, said that for ages now though, although I do still quite like my patch even if it still is useless, actually knew what I was doing for once! :) *yay me*

Note: See TracTickets for help on using tickets.