WordPress.org
Get WordPress

Make WordPress Core

Opened 16 years ago

Closed 16 years ago

#14271 closed defect (bug) (fixed)

build_query() generates invalid html

Reported by: pross Owned by:
Priority: normal Milestone: 3.1
Component: General Version: 3.0
Severity: minor Keywords:
Cc: Focuses:

Description

build_query uses & not & in creating url for use in wp_link_pages.

Will not produce valid HTML for default permalinks.

Attachments (1)

build_query.diff​ (350 bytes ) - added by pross 16 years ago.
patch

Download all attachments as: .zip

Change History (6)

@pross
16 years ago

patch

#1 @nacin
16 years ago

The idea is you then need to escape links when you want to use them as HTML, i.e. esc_url( get_permalink() ).

#2 @pross
16 years ago

ok so wp_link_pages() has to be escaped? surely wp_link_pages should produce a good link without need of another function to clean up after it?

#3 @ryan
16 years ago

Perhaps the escaping can be done in wp_link_pages, but it should not be done in build_query. That would break non-HTML uses of the function, such as in WP_HTTP.

#4 @nacin
16 years ago

  • Milestone Awaiting Review → 3.1

#5 @nacin
16 years ago

  • Resolution → fixed
  • Status new → closed

[16539]

Note: See TracTickets for help on using tickets.