WordPress.org

Make WordPress Core

Opened 5 years ago

Closed 4 years ago

#14271 closed defect (bug) (fixed)

build_query() generates invalid html

Reported by: pross Owned by:
Milestone: 3.1 Priority: normal
Severity: minor Version: 3.0
Component: General Keywords:
Focuses: Cc:

Description

build_query uses & not & in creating url for use in wp_link_pages.

Will not produce valid HTML for default permalinks.

Attachments (1)

build_query.diff (350 bytes) - added by pross 5 years ago.
patch

Download all attachments as: .zip

Change History (6)

@pross5 years ago

patch

comment:1 @nacin5 years ago

The idea is you then need to escape links when you want to use them as HTML, i.e. esc_url( get_permalink() ).

comment:2 @pross5 years ago

ok so wp_link_pages() has to be escaped? surely wp_link_pages should produce a good link without need of another function to clean up after it?

comment:3 @ryan5 years ago

Perhaps the escaping can be done in wp_link_pages, but it should not be done in build_query. That would break non-HTML uses of the function, such as in WP_HTTP.

comment:4 @nacin4 years ago

  • Milestone changed from Awaiting Review to 3.1

comment:5 @nacin4 years ago

  • Resolution set to fixed
  • Status changed from new to closed
Note: See TracTickets for help on using tickets.