Category RSS feeds in querystring format return wrong feed

[mirmillo]

In WordPress 3, using category specific RSS feeds in query string format as shown the first example here: ​http://codex.wordpress.org/WordPress_Feeds#Categories_and_Tags. WordPress returns the general site RSS feed.

For example:

​http://mirmillo.com/?cat=9&feed=rss2

​http://ryan.boren.me/?cat=1517&feed=rss2

Returns the main site feed no matter which feed format you are using.

[nacin]

Looks legit.

Can be punted without a patch in a week.

[nacin]

Submitted to GCI.

[kapeels]

This seems to happen only when permalinks are disabled.

Could anybody check?

[nacin]

Correct. I reproduced it only in that instance. The title says when using the query string format.

[kapeels]

And this happens with

​http://ryan.boren.me/?tag=test&feed=rss2

(when querying with specific tag names)

too.

[ryan]

canonical.php is redirecting back to the main feed.

[aaroncampbell]

I haven't tested this, but I was helping the student working on it for GCI in IRC. At first he wasn't able to reproduce it. After reading the description and clicking the links above, I told him it sounded like he probably needed to have permalinks enabled but use the query string notation to try to access it. Once he enabled permalinks he could reproduce it easily.

I only mention this because @kapeels says "seems to happen only when permalinks are disabled" and that seems to be incorrect.

[rfw]

Patch for canonical.php against trunk.

[rfw]

Uploaded canonical_trunk.diff, which patches canonical.php to remove $paged_redirect and use $redirect.

This also resolves failures when using paged=? in the query string.

[kapeels]

Replying to aaroncampbell:

I haven't tested this, but I was helping the student working on it for GCI in IRC. At first he wasn't able to reproduce it. After reading the description and clicking the links above, I told him it sounded like he probably needed to have permalinks enabled but use the query string notation to try to access it. Once he enabled permalinks he could reproduce it easily.

I only mention this because @kapeels says "seems to happen only when permalinks are disabled" and that seems to be incorrect.

I think somebody misunderstood :D

What I said was - this error could be reproduced only when permalinks ARE enabled. If you don't have permalinks enabled, you aren't redirected anywhere, but shown the site feed properly :)

[nacin]

Patch works. Looks good, though we will need review from Mark Jaquith for the original purpose of paged_redirect and whether this will introduce any problems that the original route aimed to solve.

[markjaquith]

(In [16920]) Fix canonical paged/feed redirects. props rfw. fixes #14288

[nacin]

(In [16928]) Remove redundancy. see #14288.