WordPress.org

Make WordPress Core

Opened 5 years ago

Last modified 7 months ago

#14310 reopened enhancement

Make template hierarchy filterable

Reported by: scribu Owned by:
Milestone: Future Release Priority: normal
Severity: normal Version:
Component: Themes Keywords: has-patch dev-feedback
Focuses: Cc:

Description (last modified by scribu)

Currently, we have filters for each template type: home_template, author_template etc.

The trouble is that these filters are applied on the final template path, after the template hierarchy has been traversed.

It would be useful if there was another filter applied to the actual template hierarchy array, before it was sent to locate_template().

Example

Take the author template hierarchy:

author-{nicename}.php > author-{id}.php > author.php

Say I want to add author-{role}.php before author.php.

Sure, I could use the 'author_template' filter:

function author_role_template( $old_template ) {
  // get current author's role

  $new_template = locate_template( array( "author-$role.php" ) );

  if( $new_template && 'author.php' == $old_template )
    return $new_template;

  return $old_template;
}
add_filter('author_template', 'author_role_template');

With an 'author_template_candidates' hook, I could manipulate the actual hierarchy:

function author_role_template( $templates ) {
  // get current author's role

  $new_template = array( "author-$role.php" );

  $templates = array_merge( 
    array_slice( $templates, 0, -1 ), // before
    $new_template,                    // inserted
    array_slice( $templates, -1 )     // after
  );

  return $templates;
}
add_filter('author_template_hierarchy', 'author_role_template');

This would allow me to remove author-{id}.php if I wanted, etc.

Attachments (6)

template_candidates.diff (4.4 KB) - added by scribu 5 years ago.
template_hierarchy.diff (4.4 KB) - added by scribu 5 years ago.
Name the filter *_template_hierarchy
template_hierarchy.2.diff (4.4 KB) - added by scribu 5 years ago.
refresh
14310.diff (428 bytes) - added by nacin 4 years ago.
template_hierarchy.3.diff (428 bytes) - added by scribu 4 years ago.
just the filter
template_hierarchy.4.diff (455 bytes) - added by scribu 2 years ago.
refresh for WP 3.6-alpha

Download all attachments as: .zip

Change History (56)

@scribu5 years ago

comment:1 @scribu5 years ago

template_candidates.diff makes all get_*_template() functions call get_query_template(), which consistently applies the appropriate filters.

comment:3 @scribu5 years ago

  • Summary changed from Template hierarchy filter to Make template hierarchy filterable

comment:4 @F J Kaiser5 years ago

  • Cc 24-7@… added

@scribu5 years ago

Name the filter *_template_hierarchy

comment:5 @scribu5 years ago

  • Description modified (diff)

template_hierarchy.diff just renames the filter *_template_hierarchy, which seems more appropriate.

@scribu5 years ago

refresh

comment:6 @scribu5 years ago

  • Resolution set to fixed
  • Status changed from new to closed

(In [15611]) Apply filters consistently in get_*_template() functions. Fixes #14310

comment:7 @azizur5 years ago

  • Cc prodevstudio+wordpress@… added

comment:8 @scribu5 years ago

Marked #15141 as dup.

comment:9 @axwax4 years ago

  • Cc axwax added

comment:10 @markjaquith4 years ago

Nacin and Koopersmith expressed concerns about this. Not necessarily about the idea, but that it didn't get any peer review or iteration. Sort of landed under the radar. get_template_part() went through a lot of revisions, for example. I'd like to give this a chance for more discussion and development before it lands in core.

comment:11 @markjaquith4 years ago

(In [17214]) Revert [15611] for 3.1. Needs more time for peer review and iteration. see #14310

comment:12 @markjaquith4 years ago

  • Milestone changed from 3.1 to Future Release
  • Resolution fixed deleted
  • Status changed from closed to reopened

comment:13 @ryan4 years ago

[17214] broke custom post type templates on wp.com.

comment:14 @coffee2code4 years ago

[15611] has been in trunk for four months, which is quite a while. Pulling it during/after RC 2 stage is rather last minute, particularly since it's being reverted more out of principle than due to bugs or lack of merit.

comment:15 @automattor4 years ago

(In [17220]) I bungled [17214]. Reverting the revert, so it can be reverted properly! see #14310

comment:16 @markjaquith4 years ago

  • Milestone changed from Future Release to 3.1
  • Resolution set to fixed
  • Status changed from reopened to closed

I must have blindly hit "tc" or "mc" in that original revert attempt. It doesn't revert cleanly.

And on second thought, lack of review or not, coffee2code and ryan made a good point: it's been in trunk for a while. Taking it out has already caused problems for people running RC code who wanted to make use of the new filters. Leaving it in. Final answer, Regis.

Sorry for the disturbance on this one. Mea culpa.

comment:17 @nacin4 years ago

  • Resolution fixed deleted
  • Status changed from closed to reopened

@nacin4 years ago

comment:18 @nacin4 years ago

Per discussion with Mark and westi, while a full revert is difficult due to code churn, this filter should never have been added to core. Re-opening for consideration.

comment:19 @westi4 years ago

I'm not convinced about the suitability of the new hook that was added here and I don't think that this has had enough discussion for us to want to keep this and preserve backwards compatibility in the future.

I would rather that we review the need for this new hook in future and discuss it more openly rather than sneak it in as part of a re-organisation of this code.

comment:20 @westi4 years ago

(In [17316]) Remove this new filter as it didn't get enough discussion prior to addition.
Revisit later. See #14310.

comment:21 @westi4 years ago

  • Milestone 3.1 deleted
  • Resolution set to fixed
  • Status changed from reopened to closed

We remembered this again whilest discussing #12877 and if we are going to try and give access to the template hierarchy then we need to have a big discussion as to why we want to change these.

comment:22 @nacin4 years ago

  • Milestone set to 3.1

comment:23 @scribu4 years ago

Fine with me.

comment:24 @scribu4 years ago

  • Milestone changed from 3.1 to Future Release
  • Resolution fixed deleted
  • Status changed from closed to reopened

Duplicate: #16994

comment:25 @scribu4 years ago

Re-opened because the original goal of this ticket wasn't achieved.

comment:26 @johnbillion4 years ago

  • Cc johnbillion@… added

@scribu4 years ago

just the filter

comment:27 follow-up: @scribu4 years ago

  • Keywords dev-feedback added

Could someone explain to me again what's wrong with the "{$type}_template_hierarchy" filter?

Do we plan to drop the hierarchy approach altogether?

Otherwise, I don't see what the big deal is, considering we already have a "{$type}_template" filter on the next line.

comment:28 in reply to: ↑ 27 @johnbillion4 years ago

Replying to scribu:

Could someone explain to me again what's wrong with the "{$type}_template_hierarchy" filter?

Anyone? I'd really love to get a filter added to the template hierarchy. Oh, the things I could do with it!

comment:29 @gruvii4 years ago

  • Cc gruvii added

comment:30 @scribu4 years ago

A similar suggestion: #17788

comment:31 @scribu4 years ago

Related: #13239.

comment:32 @ciobi4 years ago

  • Cc alex.ciobica@… added

comment:33 @navjotjsingh4 years ago

  • Cc navjotjsingh@… added

comment:34 @eddiemoya3 years ago

  • Cc eddie.moya+wptrac@… added

comment:35 @ocean903 years ago

  • Cc ocean90 added

Would be useful to extend the single hierarchy, see #18859.

comment:36 @DrewAPicture3 years ago

  • Cc xoodrew@… added

comment:37 @Bueltge3 years ago

  • Cc frank@… added

comment:38 @divinethemes3 years ago

  • Cc divinethemes added

comment:39 @bainternet3 years ago

  • Cc admin@… added

comment:40 @iandunn3 years ago

  • Cc ian_dunn@… added

comment:41 @raulillana3 years ago

  • Cc raulillana added

@scribu2 years ago

refresh for WP 3.6-alpha

comment:42 @sc0ttkclark2 years ago

  • Cc lol@… added

comment:43 @retlehs2 years ago

  • Cc retlehs added

comment:44 @louisremi2 years ago

I'm trying to recreate the template hierarchy logic on the client side with AngularJS. I want client-side templates to be picked by the Angular router based on current path and naming convention using the same rules that are used by WordPress on the server side.

The easiest way to achieve this is to get the computed array of $templates from the server side whenever the location path changes on the client side, then check which client-side template fits.

This implies that a generic filter inside get_category_template can provide the $templates array corresponding to any $type.
Unfortunately I see no alternative to this filter, and if it doesn't make it in 3.6, I will have to write a plugin that overwrites the content of wp-includes/template.php. I know this is a bad practice but there is simply no other way that I can think of.

Last edited 2 years ago by louisremi (previous) (diff)

comment:45 @emzo2 years ago

  • Cc wordpress@… added

comment:46 @talbet20 months ago

  • Cc talbet.fulthorpe@… added

comment:47 @markoheijnen20 months ago

Is this something we can add in 3.7?

comment:48 @simonwheatley20 months ago

Here's a scenario we could use this in for Babble (multilingual plugin):

We'd like to allow theme developers to provide language specific versions of templates, e.g. single-product-fr-fr.php. We can use the "{$type}_template" filter for this, but we need to replicate a lot of code when hooking it to properly handle template hierarchy.

What do we need in order to get some discussion going again, and hopefully get the "{$type}_template_hierarchy" filter into 3.7?

comment:49 @christianmagill13 months ago

I too would like to see this implemented. It would allow for implementation of much more modular templating.

comment:50 @Nabha7 months ago

We have a multi-site installation and I'd like to get all the blogs running on a single theme with a modified lookup for theme files. I think this would be needed.

For example, instead of just looking in the root theme folder for author.php, I'd like it to look for /blogs/blog-name/author.php as well. This offers a sort of intuitive way for us to override template parts.

I can kind of sort of get there with the existing filter, but not really, because the full array of searched-for templates is no longer available by the time filters are applied in get_query_template().

Last edited 7 months ago by Nabha (previous) (diff)
Note: See TracTickets for help on using tickets.