Context Navigation

← Previous Ticket
Next Ticket →

#1432 closed defect (bug) (invalid)

get_archives_link breaks HTML validation

Reported by:	ManiacSoftwareManiacsOrg	Owned by:
Priority:	normal	Milestone:
Component:	Template	Version:	1.5.1.1
Severity:	normal	Keywords:	bg\|2nd-opinion
Cc:		Focuses:

Description

get_archives_link in file wp_includes/template-functions-general.php unconditionally ends link tag with '/>' which breaks page validation for HTML documents.

If it's not very easy to distinguish somehow at this point if the document is going to be served as text/html or application/xhtml+xml then I think some additional value for $format (like 'html_link') should help this.

BTW, it would be nice also to change single quotes to double quotes here just for consistency with every other attribute across pages.

Attachments (1)

template-functions-general.php.patch (1.1 KB ) - added by MikeLittle 21 years ago.: Patch to implement this change, including quotes.

Download all attachments as: .zip

Change History (5)

#1 @skippy
21 years ago

Keywords bg|2nd-opinion added

@MikeLittle
21 years ago

Attachment template-functions-general.php.patch added

Patch to implement this change, including quotes.

#2 @MikeLittle
21 years ago

My patch uses 'htmllink' without the underscore.

#3 @nbachiyski
21 years ago

Wouldn't it be better if the value of format is 'nonxhtml' (or html4, or something like that) instead of 'html'? The latter is too general, because developers are used to refer to xhtml as html, just as a habit.

#4 @rob1n
19 years ago

Resolution → invalid
Status new → closed

You can do self-closing tags (<link />, <img />, etc.) in HTML 4.01.

Note: See TracTickets for help on using tickets.

Download in other formats:

Make WordPress Core