WordPress.org

Make WordPress Core

Opened 5 years ago

Closed 4 years ago

#14321 closed defect (bug) (fixed)

The permalink field should not show for post types that are not public

Reported by: filosofo Owned by: filosofo
Milestone: 3.1 Priority: normal
Severity: normal Version: 3.0
Component: Posts, Post Types Keywords: has-patch
Focuses: Cc:

Description

Patch shows the permalink field only for public post types.

Attachments (3)

Change History (9)

comment:1 @filosofo5 years ago

  • Owner set to filosofo
  • Status changed from new to accepted

comment:2 @markjaquith5 years ago

It still shows up after the first autosave, with this patch.

comment:3 @filosofo4 years ago

permalink-field-for-public-post-types-only.14321.2.diff fixes it so they don't show up on autosave, either.

comment:4 @nacin4 years ago

Isn't publicly_queryable enough here?

If something is publicly_queryable but not public? I would think p_q is a subset of public.

comment:5 @WraithKenny4 years ago

I was under the impression that public was a short hand property that other properties like publicly_queryable inherited from if not set. Kinda like capability_type to capabilities...

comment:6 @automattor4 years ago

  • Resolution set to fixed
  • Status changed from accepted to closed

(In [16666]) Don't show permalink box unless the post type is publicly queryable. Props filosofo. Fixes #14321

Note: See TracTickets for help on using tickets.