WordPress.org
Get WordPress

Make WordPress Core

Opened 13 years ago

Closed 13 years ago

#14321 closed defect (bug) (fixed)

The permalink field should not show for post types that are not public

Reported by: filosofo's profile filosofo Owned by: filosofo's profile filosofo
Milestone: 3.1 Priority: normal
Severity: normal Version: 3.0
Component: Posts, Post Types Keywords: has-patch
Focuses: Cc:

Description

Patch shows the permalink field only for public post types.

Attachments (3)

permalink-field-for-public-post-types-only.14321.diff​ (816 bytes) - added by filosofo 13 years ago.
permalink-field-for-public-post-types-only.14321.2.diff​ (1.2 KB) - added by filosofo 13 years ago.
permalink-field-for-public-post-types-only.14321.3.diff​ (1.2 KB) - added by filosofo 13 years ago.

Download all attachments as: .zip

Change History (9)

@filosofo
13 years ago

#1 @filosofo
13 years ago

  • Owner set to filosofo
  • Status changed from new to accepted

#2 @markjaquith
13 years ago

It still shows up after the first autosave, with this patch.

@filosofo
13 years ago

#3 @filosofo
13 years ago

permalink-field-for-public-post-types-only.14321.2.diff fixes it so they don't show up on autosave, either.

#4 @nacin
13 years ago

Isn't publicly_queryable enough here?

If something is publicly_queryable but not public? I would think p_q is a subset of public.

@filosofo
13 years ago

#5 @WraithKenny
13 years ago

I was under the impression that public was a short hand property that other properties like publicly_queryable inherited from if not set. Kinda like capability_type to capabilities...

#6 @automattor
13 years ago

  • Resolution set to fixed
  • Status changed from accepted to closed

(In [16666]) Don't show permalink box unless the post type is publicly queryable. Props filosofo. Fixes #14321

Note: See TracTickets for help on using tickets.