WordPress.org

Make WordPress Core

Opened 4 years ago

Last modified 6 months ago

#14325 new enhancement

No possibillity to add a "Home"-link to the nav_menu when there are no Pages

Reported by: lundj Owned by:
Milestone: Future Release Priority: normal
Severity: normal Version: 3.0
Component: Menus Keywords: needs-patch
Focuses: Cc:

Description

If you want to add a "Home" link to the new nav_menu in Wordpress 3.0 you can't do so, if there is no Page created yet. If there is no Page, there is also no "View All"-Button in the Pages-Section to view the "Home"-Link.

In my opinion the "Home-Link" in the Pages-Section is very hidden anyway.

Attachments (5)

14325-patch1.diff (4.2 KB) - added by Master Jake 2 years ago.
14325-patch1.png (19.9 KB) - added by DrewAPicture 2 years ago.
Screenshot of 14325-patch1.diff
14325-patch1B.png (19.9 KB) - added by DrewAPicture 2 years ago.
Left float button suggestion based on 14325-patch1.diff
14325-patch2.diff (5.3 KB) - added by DrewAPicture 2 years ago.
First try and rearranging elements
14325-patch2.png (17.4 KB) - added by DrewAPicture 2 years ago.
Screenshot of 14325-patch2.diff

Download all attachments as: .zip

Change History (24)

comment:1 lundj4 years ago

  • Cc lundj added

comment:2 mrmist4 years ago

Related support thread http://wordpress.org/support/topic/wp_nav_menu-home-menu-item-should-be-dynamic?replies=1 "Home link [should] use <?php bloginfo('url'); ?> "

comment:3 mrmist4 years ago

  • Keywords needs-patch added
  • Type changed from enhancement to defect (bug)

Also setting this to defect, as the visibility of a home link shouldn't depend on their being a Page present.

comment:4 scribu4 years ago

I agree. Having the 'Home' link in the Pages box is just confusing.

comment:5 nacin4 years ago

  • Keywords ux-feedback added
  • Milestone changed from Awaiting Review to Future Release

There isn't really a better place for it, unfortunately.

comment:6 F J Kaiser4 years ago

  • Cc 24-7@… added

comment:7 jane3 years ago

  • Milestone changed from Future Release to 3.4
  • Type changed from defect (bug) to enhancement

We should incorporate it into the menu name area. We tried it there originally for this reason but couldn't make it look good placement wise and we were running out of time. We should look again.

comment:8 sabreuse3 years ago

  • Cc sabreuse@… added

comment:9 DrewAPicture3 years ago

  • Cc xoodrew@… added

comment:10 Master Jake2 years ago

  • Cc chappellind@… added

Master Jake2 years ago

comment:11 Master Jake2 years ago

  • Keywords has-patch needs-testing dev-feedback added; needs-patch removed

DrewAPicture2 years ago

Screenshot of 14325-patch1.diff

DrewAPicture2 years ago

Left float button suggestion based on 14325-patch1.diff

comment:12 DrewAPicture2 years ago

attachment:14325-patch1.diff isn't inserting the menu item for me.

Also, attached a screenshot of @MasterJake's attachment:14325-patch1.diff

From a workflow standpoint, my main issue with the location of the Add Home Link button in attachment:1432-patch1.png is that it's so far over on the right with the 'Save Menu' button. What about floating it left, something along the lines of attachment:14325-patch1B.png?

Version 0, edited 2 years ago by DrewAPicture (next)

comment:13 follow-up: master jake2 years ago

Woah you have a HUGE resolution!! Anyways, as far as it not working, you do know you have to rename the .js file right? WordPress uses the minified one, but I submitted the patch on the dev version.

Last edited 2 years ago by master jake (previous) (diff)

comment:14 in reply to: ↑ 13 ; follow-up: DrewAPicture2 years ago

Replying to master jake:

Woah you have a HUGE resolution!! Anyways, as far as it not working, you do know you have to rename the .js file right? WordPress uses the mimicked one, but I submitted the patch on the dev version.

Ahh yes, it has indeed been a long day. I played a bit with floating the 'Add Home Link' button left but I had a heckuva time getting the 'Delete Menu' link to stay in line.

comment:15 in reply to: ↑ 14 Master Jake2 years ago

Replying to DrewAPicture:

Replying to master jake:

Woah you have a HUGE resolution!! Anyways, as far as it not working, you do know you have to rename the .js file right? WordPress uses the mimicked one, but I submitted the patch on the dev version.

Ahh yes, it has indeed been a long day. I played a bit with floating the 'Add Home Link' button left but I had a heckuva time getting the 'Delete Menu' link to stay in line.

Hehe, been a long day for me as well. I suppose if the button is having issues we could just make it a regular link.

comment:16 DrewAPicture2 years ago

attachment:14325-patch2.diff Rearranges the 'Add Home Link' button to float left.

Last edited 2 years ago by DrewAPicture (previous) (diff)

DrewAPicture2 years ago

First try and rearranging elements

DrewAPicture2 years ago

Screenshot of 14325-patch2.diff

comment:17 Master Jake2 years ago

  • Keywords ui-feedback added

I'm having mixed feelings about this one. Having that button next to a link makes the button look kind of awkward and out of place. Maybe it really should be a regular blue link (maybe underlined like the delete action is).

Last edited 2 years ago by Master Jake (previous) (diff)

comment:18 jane2 years ago

  • Milestone changed from 3.4 to Future Release

We ran out of time to hit this for 3.4. Since we are hitting freeze and this hasn't been touched, punting until next time around.

comment:19 helen6 months ago

  • Keywords needs-patch added; ux-feedback has-patch needs-testing dev-feedback ui-feedback removed

From time to time I still think about how we could incorporate a section of links that are sort of like common utiilties (terrible word for it). Think home link, maybe log in/out, plugins that create virtual pages for a shopping cart and checkout, etc. The how is probably easy enough - naming it, however, has not proven to be so. It's possible that the difficulty in naming it indicates that we are trying to marry some pretty disparate things. But in any case, we should try again, whether going that route or something special for the home link.

Note: See TracTickets for help on using tickets.