Make WordPress Core

Opened 14 years ago

Closed 9 years ago

#14325 closed enhancement (maybelater)

No possibillity to add a "Home"-link to the nav_menu when there are no Pages

Reported by: lundj's profile lundj Owned by:
Milestone: Priority: normal
Severity: normal Version: 3.0
Component: Menus Keywords: needs-patch
Focuses: Cc:

Description

If you want to add a "Home" link to the new nav_menu in Wordpress 3.0 you can't do so, if there is no Page created yet. If there is no Page, there is also no "View All"-Button in the Pages-Section to view the "Home"-Link.

In my opinion the "Home-Link" in the Pages-Section is very hidden anyway.

Attachments (5)

14325-patch1.diff (4.2 KB) - added by Master Jake 13 years ago.
14325-patch1.png (19.9 KB) - added by DrewAPicture 13 years ago.
Screenshot of 14325-patch1.diff
14325-patch1B.png (19.9 KB) - added by DrewAPicture 13 years ago.
Left float button suggestion based on 14325-patch1.diff
14325-patch2.diff (5.3 KB) - added by DrewAPicture 13 years ago.
First try and rearranging elements
14325-patch2.png (17.4 KB) - added by DrewAPicture 13 years ago.
Screenshot of 14325-patch2.diff

Download all attachments as: .zip

Change History (25)

#1 @lundj
14 years ago

  • Cc lundj added

#2 @mrmist
14 years ago

Related support thread http://wordpress.org/support/topic/wp_nav_menu-home-menu-item-should-be-dynamic?replies=1 "Home link [should] use <?php bloginfo('url'); ?> "

#3 @mrmist
14 years ago

  • Keywords needs-patch added
  • Type changed from enhancement to defect (bug)

Also setting this to defect, as the visibility of a home link shouldn't depend on their being a Page present.

#4 @scribu
14 years ago

I agree. Having the 'Home' link in the Pages box is just confusing.

#5 @nacin
14 years ago

  • Keywords ux-feedback added
  • Milestone changed from Awaiting Review to Future Release

There isn't really a better place for it, unfortunately.

#6 @F J Kaiser
14 years ago

  • Cc 24-7@… added

#7 @jane
13 years ago

  • Milestone changed from Future Release to 3.4
  • Type changed from defect (bug) to enhancement

We should incorporate it into the menu name area. We tried it there originally for this reason but couldn't make it look good placement wise and we were running out of time. We should look again.

#8 @sabreuse
13 years ago

  • Cc sabreuse@… added

#9 @DrewAPicture
13 years ago

  • Cc xoodrew@… added

#10 @Master Jake
13 years ago

  • Cc chappellind@… added

#11 @Master Jake
13 years ago

  • Keywords has-patch needs-testing dev-feedback added; needs-patch removed

@DrewAPicture
13 years ago

Screenshot of 14325-patch1.diff

@DrewAPicture
13 years ago

Left float button suggestion based on 14325-patch1.diff

#12 @DrewAPicture
13 years ago

attachment:14325-patch1.diff isn't inserting the menu item for me.

Also, attached a screenshot of @MasterJake's attachment:14325-patch1.diff

From a workflow standpoint, my main issue with the location of the Add Home Link button in attachment:14325-patch1.png is that it's so far over on the right with the 'Save Menu' button. What about floating it left, something along the lines of attachment:14325-patch1B.png?

Last edited 13 years ago by DrewAPicture (previous) (diff)

#13 follow-up: @master jake
13 years ago

Woah you have a HUGE resolution!! Anyways, as far as it not working, you do know you have to rename the .js file right? WordPress uses the minified one, but I submitted the patch on the dev version.

Last edited 13 years ago by master jake (previous) (diff)

#14 in reply to: ↑ 13 ; follow-up: @DrewAPicture
13 years ago

Replying to master jake:

Woah you have a HUGE resolution!! Anyways, as far as it not working, you do know you have to rename the .js file right? WordPress uses the mimicked one, but I submitted the patch on the dev version.

Ahh yes, it has indeed been a long day. I played a bit with floating the 'Add Home Link' button left but I had a heckuva time getting the 'Delete Menu' link to stay in line.

#15 in reply to: ↑ 14 @Master Jake
13 years ago

Replying to DrewAPicture:

Replying to master jake:

Woah you have a HUGE resolution!! Anyways, as far as it not working, you do know you have to rename the .js file right? WordPress uses the mimicked one, but I submitted the patch on the dev version.

Ahh yes, it has indeed been a long day. I played a bit with floating the 'Add Home Link' button left but I had a heckuva time getting the 'Delete Menu' link to stay in line.

Hehe, been a long day for me as well. I suppose if the button is having issues we could just make it a regular link.

#16 @DrewAPicture
13 years ago

attachment:14325-patch2.diff is my sad first effort at rearranging the elements.

Version 0, edited 13 years ago by DrewAPicture (next)

@DrewAPicture
13 years ago

First try and rearranging elements

@DrewAPicture
13 years ago

Screenshot of 14325-patch2.diff

#17 @Master Jake
13 years ago

  • Keywords ui-feedback added

I'm having mixed feelings about this one. Having that button next to a link makes the button look kind of awkward and out of place. Maybe it really should be a regular blue link (maybe underlined like the delete action is).

Last edited 13 years ago by Master Jake (previous) (diff)

#18 @jane
13 years ago

  • Milestone changed from 3.4 to Future Release

We ran out of time to hit this for 3.4. Since we are hitting freeze and this hasn't been touched, punting until next time around.

#19 @helen
11 years ago

  • Keywords needs-patch added; ux-feedback has-patch needs-testing dev-feedback ui-feedback removed

From time to time I still think about how we could incorporate a section of links that are sort of like common utiilties (terrible word for it). Think home link, maybe log in/out, plugins that create virtual pages for a shopping cart and checkout, etc. The how is probably easy enough - naming it, however, has not proven to be so. It's possible that the difficulty in naming it indicates that we are trying to marry some pretty disparate things. But in any case, we should try again, whether going that route or something special for the home link.

#20 @chriscct7
9 years ago

  • Milestone Future Release deleted
  • Resolution set to maybelater
  • Status changed from new to closed

Closing as maybelater. Complete lack of interest on the feature on the ticket over the last 4 years. Feel free to reopen when more interest re-emerges (particularly if there's a patch)

Note: See TracTickets for help on using tickets.