style confict with kubrick and hReview

[ryansking]

As described ​here, there's a style conflict with kubrick and hReview. I've created a patch that should fix the conflict without effecting other kubrick use.

The patch is available ​here.

[myelin]

As ​requested by Aaron Brazell on wp-hackers, here's a patch to rename 'description' to 'header_description' throughout Kubrick.

[myelin]

Patch to rename description class to header_description in Kubrick theme

[skeltoac]

File as a failed test case on microformats.org.

You can't patch every site that uses English words for classes. Consider using more specific classes or multiple classes:

class="hReview description"

[dougal]

As a counter-argument, I would say that the better solution is for the end-users to add a new style to their blog to specifically target the hReview description element. E.g.,

  .hReview .description { color: inherit; } 

In addition, a plugin which implemented an hReview GUI could easily add something like this via the WordPress API.

[myelin]

Unfortunately the 'inherit' property doesn't work in Internet Explorer...

skeltoac: You can't patch every site, but you can patch your own site, if you want to use microformats. Considering the overlap between Wordpress and GMPG/microformats.org, I would assume that WP would want to support microformats wherever possible.

Please consider accepting ryansking's patch - above. It's much smaller than mine and only minimally alters Kubrick's stylesheet. (I only did mine because of a mailing list request to rename the class rather than change the stylesheet).

[myelin]

Tidied version of Ryan's patch - minimum necessary to get this to work

[skeltoac]

myelin's diff is fine. It doesn't change the markup.

[ryan]

(In [3460]) Fix kubrick and hReview style conflict. Props Ryan King. fixes #1436

[(none)]

Milestone 2.0.1 deleted