WordPress.org

Make WordPress Core

Opened 9 years ago

Closed 8 years ago

Last modified 7 years ago

#1436 closed defect (bug) (fixed)

style confict with kubrick and hReview

Reported by: ryansking Owned by: matt
Milestone: Priority: low
Severity: minor Version: 2.0
Component: Template Keywords: bg|has-patch
Focuses: Cc:

Description

As described here, there's a style conflict with kubrick and hReview. I've created a patch that should fix the conflict without effecting other kubrick use.

The patch is available here.

Attachments (2)

kubrick_description_rename.diff (2.4 KB) - added by myelin 8 years ago.
Patch to rename description class to header_description in Kubrick theme
kubrick_headerimg_description_specific.diff (611 bytes) - added by myelin 8 years ago.
Tidied version of Ryan's patch - minimum necessary to get this to work

Download all attachments as: .zip

Change History (9)

comment:1 myelin8 years ago

  • Keywords hreview kubrick added
  • Milestone set to 2.0
  • Version changed from 1.5 to 2.0

As requested by Aaron Brazell on wp-hackers, here's a patch to rename 'description' to 'header_description' throughout Kubrick.

myelin8 years ago

Patch to rename description class to header_description in Kubrick theme

comment:2 skeltoac8 years ago

  • Resolution set to wontfix
  • Status changed from new to closed

File as a failed test case on microformats.org.

You can't patch every site that uses English words for classes. Consider using more specific classes or multiple classes:

class="hReview description"

comment:3 dougal8 years ago

  • Priority changed from normal to low
  • Severity changed from normal to minor

As a counter-argument, I would say that the better solution is for the end-users to add a new style to their blog to specifically target the hReview description element. E.g.,

  .hReview .description { color: inherit; } 

In addition, a plugin which implemented an hReview GUI could easily add something like this via the WordPress API.

comment:4 myelin8 years ago

  • Resolution wontfix deleted
  • Status changed from closed to reopened

Unfortunately the 'inherit' property doesn't work in Internet Explorer...

skeltoac: You can't patch every site, but you can patch your own site, if you want to use microformats. Considering the overlap between Wordpress and GMPG/microformats.org, I would assume that WP would want to support microformats wherever possible.

Please consider accepting ryansking's patch - above. It's much smaller than mine and only minimally alters Kubrick's stylesheet. (I only did mine because of a mailing list request to rename the class rather than change the stylesheet).

myelin8 years ago

Tidied version of Ryan's patch - minimum necessary to get this to work

comment:5 skeltoac8 years ago

  • Keywords bg|has-patch added; hreview kubrick removed
  • Milestone changed from 2.0 to 2.0.1
  • Owner changed from anonymous to matt
  • Status changed from reopened to new

myelin's diff is fine. It doesn't change the markup.

comment:6 ryan8 years ago

  • Resolution set to fixed
  • Status changed from new to closed

(In [3460]) Fix kubrick and hReview style conflict. Props Ryan King. fixes #1436

comment:7 anonymous7 years ago

  • Milestone 2.0.1 deleted

Milestone 2.0.1 deleted

Note: See TracTickets for help on using tickets.