WordPress.org

Make WordPress Core

Opened 4 years ago

Closed 4 years ago

#14360 closed defect (bug) (fixed)

Smilies on SSL

Reported by: tech163 Owned by: tech163
Milestone: 3.1 Priority: normal
Severity: minor Version: 3.0
Component: HTTP API Keywords:
Focuses: Cc:

Description

When I have smiles in comments, they are not served in SSL, even if I enabled FORCE_SSL_ADMIN in wp-config.

I think this can be fixed by changing:

	$siteurl = get_option( 'siteurl' );

to

	$siteurl = get_option( 'siteurl' );

	if($_SERVER['HTTPS'] == 'on') {
		if(substr($siteurl, 0, 5) == 'http:') {
			$siturl = 'https:' . substr($siteurl, 5);
		}
	}

on line 1427 of /wp-includes/formatting.php.

Can someone else verify that this works?

Attachments (2)

formatting.diff (287 bytes) - added by tech163 4 years ago.
14360.diff (668 bytes) - added by ryan 4 years ago.
Use includes_url()

Download all attachments as: .zip

Change History (5)

comment:1 nacin4 years ago

  • Milestone changed from Awaiting Review to 3.1

A simple switch from get_option('site_url') to site_url() will handle that.

And really, the whole thing should instead use includes_url() and then pass that result to the filter.

tech1634 years ago

comment:2 tech1634 years ago

  • Owner set to tech163
  • Status changed from new to accepted

ryan4 years ago

Use includes_url()

comment:3 ryan4 years ago

  • Resolution set to fixed
  • Status changed from accepted to closed

(In [15554]) Make smilies links SSL aware. Props tech163. fixes #14360

Note: See TracTickets for help on using tickets.