Opened 16 years ago
Closed 16 years ago
#14360 closed defect (bug) (fixed)
Smilies on SSL
| Reported by: | tech163 | Owned by: | tech163 |
|---|---|---|---|
| Priority: | normal | Milestone: | 3.1 |
| Component: | HTTP API | Version: | 3.0 |
| Severity: | minor | Keywords: | |
| Cc: | Focuses: |
Description
When I have smiles in comments, they are not served in SSL, even if I enabled FORCE_SSL_ADMIN in wp-config.
I think this can be fixed by changing:
$siteurl = get_option( 'siteurl' );
to
$siteurl = get_option( 'siteurl' );
if($_SERVER['HTTPS'] == 'on') {
if(substr($siteurl, 0, 5) == 'http:') {
$siturl = 'https:' . substr($siteurl, 5);
}
}
on line 1427 of /wp-includes/formatting.php.
Can someone else verify that this works?
Attachments (2)
Change History (5)
Note:
See TracTickets
for help on using tickets.
![(please configure the [header_logo] section in trac.ini)](/chrome/site/your_project_logo.png)
A simple switch from get_option('site_url') to site_url() will handle that.
And really, the whole thing should instead use includes_url() and then pass that result to the filter.