WordPress.org

Make WordPress Core

Opened 5 years ago

Closed 4 years ago

#14384 closed defect (bug) (fixed)

wp-admin says "1" Update in sidebar then I click and it disappears

Reported by: projectoscarwp Owned by: westi
Milestone: 3.2 Priority: normal
Severity: minor Version: 3.0
Component: Upgrade/Install Keywords:
Focuses: Cc:

Description

Sometimes when I'm on the Dashboard the Sidebar will show 1 in the "Updates" link so I click it, and then it disappears on the reload and there is no update to be found on the page.

Change History (14)

comment:1 @scribu5 years ago

  • Component changed from General to Upgrade/Install

comment:2 follow-up: @dd325 years ago

  • Keywords updates 1 ghost removed

Have you ever noticed it happen with the Plugins menu at all? Or just the Dashboard update notification

comment:3 in reply to: ↑ 2 @projectoscarwp5 years ago

Replying to dd32:

Have you ever noticed it happen with the Plugins menu at all? Or just the Dashboard update notification

The "Updates" notification has been the only one to appear solo. Whenever the "Plugins" notification appears, there is an update available and the "Updates" shows as well.

comment:4 follow-up: @duck_5 years ago

  • Keywords reporter-feedback close added
  • Milestone Awaiting Review deleted

I imagine the reporter is using a plugin which obscures the WordPress version number, but only on the front end. If the version check cron is called from the front end the .org API will report the availability of an update. Go back to the admin and _maybe_update_core will clear this as it's hooked to admin_init, but not before the menu is built containing the update bubble. The bubble will be gone on the next page load.

wp_version_check and other related functions could include version.php instead of relying on the global (hat-tip nacin).

comment:5 @dd325 years ago

  • Milestone set to Awaiting Review

Throwing it back in with the rest of the tickets, We can probably implement nacin's idea in 3.2 however

comment:6 in reply to: ↑ 4 @westi5 years ago

Replying to duck_:

wp_version_check and other related functions could include version.php instead of relying on the global (hat-tip nacin).

I'm almost tempted to make it a define but then people would abuse that instead and it would break the way wp-beta-tester works ;-)

comment:7 @dd325 years ago

  • Keywords 3.2-early added; reporter-feedback close removed
  • Milestone changed from Awaiting Review to Future Release

I think we should go the include version.php method here, save potential problems.

comment:8 @dd324 years ago

  • Milestone changed from Future Release to 3.2

comment:9 @dd324 years ago

  • Resolution set to fixed
  • Status changed from new to closed

(In [17619]) Ensure that the Update API's are always using a non-modified $wp_version. Props nacin. Fixes #14384

comment:10 @westi4 years ago

  • Resolution fixed deleted
  • Status changed from closed to reopened

This breaks the beta tester plugin

comment:11 @dd324 years ago

I've sent westi a patch for the beta tester plugin to use an alternate method here. It'll affect the usage of the plugin on 3.2 upgrading to 3.3-alpha or 3.2.x nightlies, so I'll leave this in trunk for now.

comment:12 follow-up: @ocean904 years ago

  • Cc westi added
  • Keywords 3.2-early removed

westi, what is with the patch from dd32?

comment:13 in reply to: ↑ 12 @westi4 years ago

  • Owner set to westi
  • Status changed from reopened to reviewing

Replying to ocean90:

westi, what is with the patch from dd32?

Committed (at last) http://plugins.trac.wordpress.org/changeset/393346

comment:14 @westi4 years ago

  • Resolution set to fixed
  • Status changed from reviewing to closed
Note: See TracTickets for help on using tickets.