WordPress.org

Make WordPress Core

Opened 4 years ago

Closed 4 years ago

#14385 closed enhancement (fixed)

Allow flagging of a blog as mature via a URL

Reported by: Viper007Bond Owned by:
Milestone: 3.1 Priority: normal
Severity: normal Version: 3.0
Component: Administration Keywords: needs-refresh
Focuses: Cc:

Description (last modified by Viper007Bond)

Add matureblog and unmatureblog actions to ms-edit.php so you can "one" click mark a blog as mature.

The option isn't listed by default on the "Sites" listing, but it can be used elsewhere.

Attachments (3)

14385.patch (4.6 KB) - added by Viper007Bond 4 years ago.
Add mature/unmature actions and do some minor formatting cleanup
14385.2.patch (1.0 KB) - added by Viper007Bond 4 years ago.
Mature/unmature actions only, leave cleanup for another ticket
14385.3.patch (1.7 KB) - added by Viper007Bond 4 years ago.
Mature/unmature actions and add hooks to them as well as the spam actions (the other actions already have their own hooks)

Download all attachments as: .zip

Change History (13)

Viper007Bond4 years ago

Add mature/unmature actions and do some minor formatting cleanup

comment:1 follow-up: nacin4 years ago

These were actually removed from a patch written by ocean90 and committed by me, I think. My points at the time, IIRC:

  1. They didn't exist as action links in MU.
  2. Of the action links, IMO they would be the least used and least useful, and just take up space, and as it was there were plenty of action links there.
  3. "Mature" means absolutely nothing in MS by default, if I'm not mistaken. It does nothing beyond flip a bit. It's up to the network to then implement it. (See also point 2.)
  4. If a plugin can't implement this, then we should be sure the proper hooks in place are there.

Your thoughts? I honestly don't care either way, but I didn't see it as something needing an action link.

Viper007Bond4 years ago

Mature/unmature actions only, leave cleanup for another ticket

comment:2 nacin4 years ago

  • Milestone changed from Awaiting Review to 3.1

Fail.

Completely missed that all this patch did was add the backend handler, not any action links.

+1.

comment:3 in reply to: ↑ 1 Viper007Bond4 years ago

Replying to nacin:

My points at the time, IIRC:

I'm not suggesting adding the UI for this anywhere. It is indeed a low used feature and most sites won't use it. No need to clutter.

However even if I used a plugin to add such a link below the blog's name on the Sites screen, it wouldn't do anything as there's no such action in the POST handling script. I'd have to write a whole custom GET string, handler, etc. This simple patch just adds the handler.

comment:4 Viper007Bond4 years ago

  • Description modified (diff)

comment:5 Viper007Bond4 years ago

I noticed that the spam/unspam actions don't have hooks like the other actions do, so I added some to them as well as my new mature actions.

Viper007Bond4 years ago

Mature/unmature actions and add hooks to them as well as the spam actions (the other actions already have their own hooks)

comment:6 ryan4 years ago

Move actions to update_blog_status(). It already has make_spam_blog and make_ham_blog.

comment:7 nacin4 years ago

  • Keywords needs-refresh added; has-patch needs-testing removed

Needs refresh per ryan's guidance.

comment:8 follow-up: technosailor4 years ago

Hmmm, I know everyone seems signed off on this but I really do believe this is plugin territory. In fact, I already see mature in the list of blog stati on line 515 of wp-admin/ms-blogs.php. Not sure why that would or should be there, considering. Can we just filter the array of blog_statuses, and add an action before the return at the end of the update_blog_status() function.

Happy to write that patch.

comment:9 in reply to: ↑ 8 nacin4 years ago

Replying to technosailor:

Hmmm, I know everyone seems signed off on this but I really do believe this is plugin territory.

I made the same assumption you did. No UI here, just POSt handling that can be utilized.

comment:10 ryan4 years ago

  • Resolution set to fixed
  • Status changed from new to closed

(In [15836]) Allow flagging of a blog as mature via a URL. Move some actions into update_blog_status(). Props Viper007Bond. fixes #14385

Note: See TracTickets for help on using tickets.