WordPress.org

Make WordPress Core

Opened 5 years ago

Closed 4 years ago

#14394 closed defect (bug) (fixed)

Attach Media dialog handles enter keyPress incorrectly

Reported by: mdawaffe Owned by:
Milestone: 3.1 Priority: normal
Severity: normal Version: 3.0
Component: Media Keywords: has-patch
Focuses: Cc:

Description

Pressing the enter key while searching for posts in the Attach Media dialog causes the global posts-filter form to submit instead of the AJAX based search results action.

  1. Go to Media -> Add New
  2. Upload an image.
  3. Go to Media -> Unattached.
  4. Find new image, click "Attach".
  5. Enter search term in text box.
  6. Hit Enter.

Attached detects an enter keypress from any appropriate input to stop the form submission and grab the search results instead.

Attached removes inline JS.

Committer: Attached does not include diff to production JS.

Attachments (1)

14394.diff (1.9 KB) - added by mdawaffe 5 years ago.

Download all attachments as: .zip

Change History (2)

@mdawaffe5 years ago

comment:1 @ryan4 years ago

  • Resolution set to fixed
  • Status changed from new to closed

(In [15918]) Fix media dialog keyPress handling. Props mdawaffe. fixes #14394

Note: See TracTickets for help on using tickets.