Twenty Ten: add height to twentyten_attachment_size filter

[iandstewart]

In hindsight, the (essentially limitless) height for gallery images on attachment pages looks to be too much. 900px wide portrait images wind up looking way too large in galleries.

The attached diff uses the filterable width limit of 900px for the height limit as well. It puts the bulk of really large portrait-oriented images on screen while still looking appropriately sized when mixed with full-width landscape-oriented images in a gallery.

[nacin]

Could we do this in a way that causes them to be filterable independently? What about passing them to a new filter as an array?

If that seems unnecessary, then that's fine too.

[lancewillett]

Adding refreshed patch that filters the height and width separately (as an array).

[nacin]

This breaks any existing uses of twentyten_attachment_size.

[lancewillett]

Replying to nacin:

This breaks any existing uses of twentyten_attachment_size.

Back compat be darned! Mwahahaha. Just kidding. I'll work on a better patch that introduces a new filter and leaves the old one as it was.

[lancewillett]

14402.refreshed-2.diff moves the code to functions.php and applies the old filter for width for back compat.

[nacin]

(In [17305]) Add twentyten_attachment_height filter. props lancewillett, fixes #14402.