WordPress.org

Make WordPress Core

Opened 7 years ago

Closed 5 years ago

#14406 closed enhancement (fixed)

consistent register link filtering

Reported by: wpmuguru Owned by: SergeyBiryukov
Milestone: 3.6 Priority: normal
Severity: minor Version:
Component: Administration Keywords: 3.2-early has-patch commit
Focuses: Cc:

Description (last modified by wpmuguru)

The register link is filtered in the meta widget, but not in the login form. If someone builds a custom signup page process, they have to catch the $_GET['action'] == 'register' which isn't very elegant or consistent.

The attached patch uses the wp_register function in wp-login.php to provide consistent filtering of the registration link.

Attachments (3)

14406.diff (1.2 KB) - added by wpmuguru 7 years ago.
14406.2.diff (647 bytes) - added by wonderboymusic 5 years ago.
14406.3.diff (2.2 KB) - added by SergeyBiryukov 5 years ago.

Download all attachments as: .zip

Change History (12)

@wpmuguru
7 years ago

#1 @wpmuguru
7 years ago

  • Description modified (diff)

#2 @scribu
7 years ago

  • Keywords needs-refresh added

#3 @ryan
7 years ago

Can't that lead to the site admin link being displayed. Perhaps the 'register' filter should be applied directly. wp_register() is pretty lame, anyway. It applies the same filter for two different links. :-)

#4 @nacin
7 years ago

  • Keywords needs-patch 3.2-early added; has-patch needs-refresh removed
  • Milestone changed from 3.1 to Future Release

#5 @wonderboymusic
5 years ago

  • Keywords has-patch added; needs-patch removed
  • Milestone changed from Future Release to 3.6

Filter it is

#6 @SergeyBiryukov
5 years ago

Seems like the filter should be applied to all the three instances. Done in 14406.3.diff.

#8 @SergeyBiryukov
5 years ago

  • Keywords commit added

#9 @SergeyBiryukov
5 years ago

  • Owner set to SergeyBiryukov
  • Resolution set to fixed
  • Status changed from new to closed

In 23558:

Consistently apply 'register' filter. props wonderboymusic for initial patch. fixes #14406.

Note: See TracTickets for help on using tickets.