Add wp-caption-text to caption class for Gallery Shortcode

[chipbennett]

wp-includes\media.php - line 855

Replace <{$captiontag} class='gallery-caption'>

with <{$captiontag} class='gallery-caption wp-caption-text'>

Adding wp-caption-text to the class declaration for Gallery image captions will facilitate styling media-manager-inserted images consistently, without having to define multiple style declarations. Since existing Gallery shortcode users will have already defined gallery-caption, this declaration should remain.

[chipbennett]

This is my first attempt at creating a patch. Please advise if I've done anything incorrectly.

[filosofo]

You should generate the patch file from WP's root, instead of a sub-directory such as wp-includes (as you did here). Doing so makes it easy for the committer to apply the patch.

[chipbennett]

Diff created from root, rather than from wp-includes

[chipbennett]

Re-generated the patch. How is it now?

[iandstewart]

Sounds good to me. I can see allowing themers to style both single-image and gallery-image captions in one fell swoop with a single class being pretty useful.

[lancewillett]

Replying to chipbennett:

Re-generated the patch. How is it now?

Patch look good. I think this will be come in handy.

[nacin]

[16864]